Noticed on the Edit item screen and the Issues screen
Aleisha did a git bisect to see what caused the issue 854c0fc1dea9435e35832a5190847aa7f922335e is the first bad commit commit 854c0fc1dea9435e35832a5190847aa7f922335e Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Wed Jan 11 15:20:28 2023 +0100 Bug 32609: Remove CSS and JS compiled files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit dcf772cb7026b4ed21caf6b055f8260140dcefdb) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> koha-tmpl/intranet-tmpl/prog/css/calendar.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/holds.css | 1 - koha-tmpl/intranet-tmpl/prog/css/installer.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 1 - koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 9 --------- koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 1 - 11 files changed, 35 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/calendar.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/holds.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/installer.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/mainpage.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/staff-global.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco.css
I think bug 32978 might be the root cause of this one. As I noted on bug 33621 it looks like the problem is that a hash (ie #) isn't being encoded when it should be. I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss
Created attachment 150261 [details] pic
(In reply to David Cook from comment #2) > I think bug 32978 might be the root cause of this one. > > As I noted on bug 33621 it looks like the problem is that a hash (ie #) > isn't being encoded when it should be. > > I think the fix is probably to change fill='#369' to fill='%23369' in > ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss this seems to have fixed the problem, tested in master (pic attached)
Created attachment 150262 [details] [review] Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible
The patch fixes the problem but I don't understand why the problem has been caused by bug 32609.
(In reply to David Cook from comment #2) > I think bug 32978 might be the root cause of this one. I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn css:build => no icon
(In reply to Jonathan Druart from comment #7) > (In reply to David Cook from comment #2) > > I think bug 32978 might be the root cause of this one. > > I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn > css:build => no icon I'm not familiar enough with the process but perhaps a person needs to remove all node_modules and all built files as well?
Created attachment 150315 [details] [review] Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. In the staff interface, edit and item for a record. 2. Note that there is no calendar icon in the 'd - Date acquired' input field. 3. Apply the patch. 4. Rebuild: yarn build 5. Restart all the things: flush_memecached, restart_all 6. Repeat step 1 (refresh the page if required). 7. There is now a calendar icon in the date acquired field.
Created attachment 150323 [details] [review] Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release