Bug 33615 - Date picker icon not visible
Summary: Date picker icon not visible
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Aleisha Amohia
URL:
Keywords: rel_22_11_candidate
Depends on: 32978
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-26 04:27 UTC by wainuiwitikapark
Modified: 2023-06-13 16:26 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
pic (139.04 KB, image/png)
2023-04-27 02:57 UTC, Mason James
Details
Bug 33615: Date picker icon not visible (4.95 KB, patch)
2023-04-27 03:26 UTC, Mason James
Details | Diff | Splinter Review
Bug 33615: Date picker icon not visible (5.00 KB, patch)
2023-04-27 19:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 33615: Date picker icon not visible (5.06 KB, patch)
2023-04-27 23:02 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description wainuiwitikapark 2023-04-26 04:27:55 UTC
Noticed on the Edit item screen and the Issues screen
Comment 1 wainuiwitikapark 2023-04-26 04:31:41 UTC
Aleisha did a git bisect to see what caused the issue

854c0fc1dea9435e35832a5190847aa7f922335e is the first bad commit
commit 854c0fc1dea9435e35832a5190847aa7f922335e
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Wed Jan 11 15:20:28 2023 +0100

    Bug 32609: Remove CSS and JS compiled files
    
    Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
    (cherry picked from commit dcf772cb7026b4ed21caf6b055f8260140dcefdb)
    Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

 koha-tmpl/intranet-tmpl/prog/css/calendar.css     | 9 ---------
 koha-tmpl/intranet-tmpl/prog/css/holds.css        | 1 -
 koha-tmpl/intranet-tmpl/prog/css/installer.css    | 9 ---------
 koha-tmpl/intranet-tmpl/prog/css/mainpage.css     | 1 -
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 9 ---------
 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css    | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css        | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css   | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/print.css       | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css     | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/sco.css         | 1 -
 11 files changed, 35 deletions(-)
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/calendar.css
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/holds.css
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/installer.css
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/mainpage.css
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/staff-global.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css
 delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco.css
Comment 2 David Cook 2023-04-27 00:27:37 UTC
I think bug 32978 might be the root cause of this one. 

As I noted on bug 33621 it looks like the problem is that a hash (ie #) isn't being encoded when it should be.

I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss
Comment 3 Mason James 2023-04-27 02:57:21 UTC
Created attachment 150261 [details]
pic
Comment 4 Mason James 2023-04-27 02:58:14 UTC
(In reply to David Cook from comment #2)
> I think bug 32978 might be the root cause of this one. 
> 
> As I noted on bug 33621 it looks like the problem is that a hash (ie #)
> isn't being encoded when it should be.
> 
> I think the fix is probably to change fill='#369' to fill='%23369' in
> ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss

this seems to have fixed the problem, tested in master (pic attached)
Comment 5 Mason James 2023-04-27 03:26:42 UTC
Created attachment 150262 [details] [review]
Bug 33615: Date picker icon not visible

to test:

 - apply patch, build package

 - edit item, observe calendar icon is visible
Comment 6 Jonathan Druart 2023-04-27 04:35:17 UTC
The patch fixes the problem but I don't understand why the problem has been caused by bug 32609.
Comment 7 Jonathan Druart 2023-04-27 04:41:51 UTC
(In reply to David Cook from comment #2)
> I think bug 32978 might be the root cause of this one. 

I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn css:build => no icon
Comment 8 David Cook 2023-04-27 04:52:56 UTC
(In reply to Jonathan Druart from comment #7)
> (In reply to David Cook from comment #2)
> > I think bug 32978 might be the root cause of this one. 
> 
> I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn
> css:build => no icon

I'm not familiar enough with the process but perhaps a person needs to remove all node_modules and all built files as well?
Comment 9 David Nind 2023-04-27 19:31:15 UTC
Created attachment 150315 [details] [review]
Bug 33615: Date picker icon not visible

to test:

 - apply patch, build package

 - edit item, observe calendar icon is visible

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2023-04-27 20:29:57 UTC
Testing notes (using KTD):

1. In the staff interface, edit and item for a record.
2. Note that there is no calendar icon in the 'd - Date acquired' input field.
3. Apply the patch.
4. Rebuild: yarn build
5. Restart all the things: flush_memecached, restart_all
6. Repeat step 1 (refresh the page if required).
7. There is now a calendar icon in the date acquired field.
Comment 11 Aleisha Amohia 2023-04-27 23:02:10 UTC
Created attachment 150323 [details] [review]
Bug 33615: Date picker icon not visible

to test:

 - apply patch, build package

 - edit item, observe calendar icon is visible

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 12 Tomás Cohen Arazi 2023-05-05 15:15:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 13 Martin Renvoize 2023-05-12 15:24:01 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release