Hello all, Update of the data with the values introduced in 2022 concerning unimarc_field_110.pl Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze)
Created attachment 150714 [details] [review] Bug 33686: Update plugin unimarc_field_110.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre
Created attachment 150790 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values Was missing : - ib : birman - ic : khmer - jb : bengali - jc : gujurati - jd : gurmukhi - je : odia (oriya) - lb : kannada (kannara) - lc : malayalam - ld : singhalais (cinghalais) - le : télougou - na : éthiopien (guèze) Sponsored by BibLibre Signed-off-by: David Nind <david@davidnind.com>
I've signed off, as this adds the new values in the 2022 UNIMARC update. However, I do have a question: should the script of title name values match exactly with the UNIMARC definitions (see references)? For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), but in Koha it is shown as eg Dongba (Naxi). If they should, I'm happy to create a bug for that. References: 1. UNIMARC Bibliographic (3rd ed.) Updates https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with-updates/ 2. Tag 100 values (see page 8 for 'Script of title') https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Testing notes (using KTD): 1. Before starting KTD, edit your .env file to change KOHA_MARC_FLAVOUR=unimarc 2. Edit a record and view the values for tag 100 and the 'Script of title' dropdown list. 3. Codes and names for values being added by this bug are not listed. 4. Apply the patch. 5. Restart everything (flush_memcached, restart_all, clear browser cache). 6. Repeat step 2. 7. New codes and values are now lsited.
Comment on attachment 150790 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values >From 0fc81a34b3ff8e6eaf1b1270282a31cfc8453c8b Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Fri, 5 May 2023 13:01:23 +0200 >Subject: [PATCH] Bug 33686: Update plugin unimarc_field_100.pl with 2022 > values >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Was missing : > >- ib : birman >- ic : khmer >- jb : bengali >- jc : gujurati >- jd : gurmukhi >- je : odia (oriya) >- lb : kannada (kannara) >- lc : malayalam >- ld : singhalais (cinghalais) >- le : télougou >- na : éthiopien (guèze) > >Sponsored by BibLibre > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../value_builder/unimarc_field_100.tt | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >index 103e8949cc..23e43cff13 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt >@@ -685,6 +685,16 @@ > [% ELSE %] > <option value="ia">ia- Thai</option> > [% END %] >+ [% IF ( f15ib ) %] >+ <option value="ib" selected="selected">ib- Birman</option> >+ [% ELSE %] >+ <option value="ib">ib- Birman</option> >+ [% END %] >+ [% IF ( f15ic ) %] >+ <option value="ic" selected="selected">ic- Khmer</option> >+ [% ELSE %] >+ <option value="ic">ic- Khmer</option> >+ [% END %] > [% IF ( f15id ) %] > <option value="id" selected="selected">id- Laotian</option> > [% ELSE %] >@@ -700,6 +710,26 @@ > [% ELSE %] > <option value="ja">ja- Devanagari</option> > [% END %] >+ [% IF ( f15jb ) %] >+ <option value="jb" selected="selected">jb- Bengali</option> >+ [% ELSE %] >+ <option value="jb">jb- Bengali</option> >+ [% END %] >+ [% IF ( f15jc ) %] >+ <option value="jc" selected="selected">jc- Gujurati</option> >+ [% ELSE %] >+ <option value="jc">jc- Gujurati</option> >+ [% END %] >+ [% IF ( f15jd ) %] >+ <option value="jd" selected="selected">jd- Gurmukhi</option> >+ [% ELSE %] >+ <option value="jd">jd- Gurmukhi</option> >+ [% END %] >+ [% IF ( f15je ) %] >+ <option value="je" selected="selected">je- Odia (oriya)</option> >+ [% ELSE %] >+ <option value="je">je- Odia (oriya)</option> >+ [% END %] > [% IF ( f15jf ) %] > <option value="jf" selected="selected">jf- Tibetan</option> > [% ELSE %] >@@ -720,6 +750,26 @@ > [% ELSE %] > <option value="la">la- Tamil</option> > [% END %] >+ [% IF ( f15lb ) %] >+ <option value="lb" selected="selected">lb- Kannada (kannara)</option> >+ [% ELSE %] >+ <option value="lb">lb- Kannada (kannara)</option> >+ [% END %] >+ [% IF ( f15lc ) %] >+ <option value="lc" selected="selected">lc- Malayalam</option> >+ [% ELSE %] >+ <option value="lc">lc- Malayalam</option> >+ [% END %] >+ [% IF ( f15ld ) %] >+ <option value="ld" selected="selected">ld- Singhalais (cinghalais)</option> >+ [% ELSE %] >+ <option value="ld">ld- Singhalais (cinghalais)</option> >+ [% END %] >+ [% IF ( f15le ) %] >+ <option value="le" selected="selected">le- Tégoulou</option> >+ [% ELSE %] >+ <option value="le">le- Tégoulou</option> >+ [% END %] > [% IF ( f15lf ) %] > <option value="lf" selected="selected">lf- Grantha</option> > [% ELSE %] >@@ -735,6 +785,11 @@ > [% ELSE %] > <option value="mb">mb- Armenian</option> > [% END %] >+ [% IF ( f15na ) %] >+ <option value="na" selected="selected">na- Ethiopien (guèze)</option> >+ [% ELSE %] >+ <option value="na">na- Ethiopien (guèze)</option> >+ [% END %] > [% IF ( f15nb ) %] > <option value="nb" selected="selected">nb- Tifinagh (Berber alphabet)</option> > [% ELSE %] >-- >2.30.2
Created attachment 150933 [details] [review] Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Did test it now under MySQL 8. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 150934 [details] [review] Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
Created attachment 150935 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
Created attachment 150936 [details] [review] Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
Created attachment 150937 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Current status: Needs Signoff
Created attachment 150938 [details] [review] Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf
(In reply to David Nind from comment #3) > I've signed off, as this adds the new values in the 2022 UNIMARC update. > > However, I do have a question: should the script of title name values match > exactly with the UNIMARC definitions (see references)? > > For example, in the definitions eg is shown as eg Naxi Dongba (Nakhi Tomba), > but in Koha it is shown as eg Dongba (Naxi). > > If they should, I'm happy to create a bug for that. > > References: > 1. UNIMARC Bibliographic (3rd ed.) Updates > https://www.ifla.org/g/unimarc-rg/unimarc-bibliographic-3rd-edition-with- > updates/ > 2. Tag 100 values (see page 8 for 'Script of title') > https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf > > Testing notes (using KTD): > 1. Before starting KTD, edit your .env file to change > KOHA_MARC_FLAVOUR=unimarc > 2. Edit a record and view the values for tag 100 and the 'Script of title' > dropdown list. > 3. Codes and names for values being added by this bug are not listed. > 4. Apply the patch. > 5. Restart everything (flush_memcached, restart_all, clear browser cache). > 6. Repeat step 2. > 7. New codes and values are now lsited. Hello David, Indeed there are some terms which are not exactly the same as those of the ifla document, I propose a correction of those in a differentiated commit (only concerning the section "Script of title" to be precise with the BZ title). I took the opportunity to change the title of the BZ, there was an error concerning the value builder, it is 100 and not 110 as previously indicated. Thanks
Created attachment 151178 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com>
Created attachment 151179 [details] [review] Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com>
Created attachment 151340 [details] [review] Bug 33686: Update plugin unimarc_field_100.pl with 2022 values According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 151341 [details] [review] Bug 33686: Correction of existing terms related to 'Script of title' According to https://cdn.ifla.org/wp-content/uploads/U_B_100_update2022_online_final.pdf Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x