Bug 33711 - Refine the token passing mechanisms introduced in bug 23336
Summary: Refine the token passing mechanisms introduced in bug 23336
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact:
URL:
Keywords:
Depends on: 23336
Blocks: 33712
  Show dependency tree / graph
 
Reported: 2023-05-10 12:12 UTC by Martin Renvoize (ashimema)
Modified: 2023-05-10 12:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2023-05-10 12:12:31 UTC 
Bug 23336 introduces an API workflow for checkouts by adding two endpoints.. one for availability that creates a token for confirmations that can then be used by the checkouts endpoint to verify that availability has been checked.

Whilst I think the availability endpoint is worthwhile in it's own right, I think we could also send back the token in the 409 pre-condition failed response of the checkouts endpoint so one could use that single endpoint for double duty in the right circumstances.

I also think we could work on how the confirmation token is sent to the endpoint.. it's currently a simple query param but may lend itself to being part of the x-koha-overrides header or another header?