Bug 33748 - UI issue on addorderiso2709.pl page
Summary: UI issue on addorderiso2709.pl page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-16 17:38 UTC by Lucas Gass
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33748: Fix UI issue when importing records from a staged MARC file (2.67 KB, patch)
2023-05-16 17:41 UTC, Lucas Gass
Details | Diff | Splinter Review
22.05 match (59.22 KB, image/png)
2023-05-16 20:09 UTC, Barbara Johnson
Details
22.05 no match (37.08 KB, image/png)
2023-05-16 20:09 UTC, Barbara Johnson
Details
22.11 style match (54.88 KB, image/png)
2023-05-16 20:10 UTC, Barbara Johnson
Details
22.11 style no match (49.47 KB, image/png)
2023-05-16 20:10 UTC, Barbara Johnson
Details
Bug 33748: Fix UI issue when importing records from a staged MARC file (35.69 KB, patch)
2023-05-16 23:03 UTC, Lucas Gass
Details | Diff | Splinter Review
Original display after updated patch (64.03 KB, image/png)
2023-05-17 15:56 UTC, Barbara Johnson
Details
Display after suggested tweaks (60.75 KB, image/png)
2023-05-17 15:57 UTC, Barbara Johnson
Details
Missing edit_item_form (92.04 KB, image/png)
2023-05-17 15:57 UTC, Barbara Johnson
Details
Bug 33748: Fix UI issue when importing records from a staged MARC file (6.23 KB, patch)
2023-05-25 22:11 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33748: Fix UI issue when importing records from a staged MARC file (6.30 KB, patch)
2023-05-25 22:57 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33748: Fix UI issue when importing records from a staged MARC file (6.37 KB, patch)
2023-06-01 07:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-05-16 17:38:32 UTC
How I recreated:

1. Set  MarcItemFieldsToOrder like this:

homebranch: 975$a
holdingbranch: 975$b
itype: 975$y
nonpublic_note: 975$x
public_note: 975$z
loc: 975$c
ccode: 975$8
notforloan: 975$7
quantity: 975$q
price: 975$g
replacementprice: 975$v
uri: 975$u

2. Set MarcFieldsToOrder like this: 

price: 975$p
quantity: 975$q
budget_code: 975$h

3. Stage a MARC file that has bibs with items. 
4. From acquisitions create a new basket and add 'From a staged file'

Notices that the Item record X info is pushed to the left and the 'Match' label has a border running right through it.
Comment 1 Lucas Gass 2023-05-16 17:41:01 UTC Comment hidden (obsolete)
Comment 2 Barbara Johnson 2023-05-16 20:07:34 UTC
The patch did help improve the style but I see several issues:

In 22.05 the data for Item record 1, item record 2, etc. displayed on the right side of the screen.  It was nice to be able to visually connect the item data with the order data displayed directly to the left.  It also makes good use of screen real estate and decreases the amount of scrolling down to the bottom in order to save.

In 22.05 if there was no matching record nothing was displayed.  In 22.11 the word Match: displays with no additional info since there is no match.  It seems like this is extraneous and should be removed for non-matches.

I attached two screenshots for the display in 22.05 and two for how it is now displaying in 22.11.
Comment 3 Barbara Johnson 2023-05-16 20:09:30 UTC
Created attachment 151323 [details]
22.05 match
Comment 4 Barbara Johnson 2023-05-16 20:09:51 UTC
Created attachment 151324 [details]
22.05 no match
Comment 5 Barbara Johnson 2023-05-16 20:10:12 UTC
Created attachment 151325 [details]
22.11 style match
Comment 6 Barbara Johnson 2023-05-16 20:10:35 UTC
Created attachment 151326 [details]
22.11 style no match
Comment 7 Lucas Gass 2023-05-16 23:03:17 UTC Comment hidden (obsolete)
Comment 8 Lucas Gass 2023-05-16 23:03:47 UTC
Barbara,

Can you test my new patch?
Comment 9 Barbara Johnson 2023-05-17 15:56:19 UTC
The display is much better now.  Here are several things to take a look at:

The three action buttons for the items are sitting right on top of a thin border line.  Some space between the buttons would look better.  Or, is the line needed at all?

Since the item labels are of different widths it makes the input boxes display in a staggered fashion.  It would be easier to view if the labels were all one width so that the input boxes could align.  It was that way for me in 22.05 but it's possible I put some code in place to do that.

If there is no match for the bib then 'Match:' is just hanging above the order info with no purpose.  It did not display at all in 22.05 if there was no match.  

When clicking on the 'Item information' tab the edit_item_form does not display.

I've attached a few screenshots.
Comment 10 Barbara Johnson 2023-05-17 15:56:59 UTC
Created attachment 151345 [details]
Original display after updated patch
Comment 11 Barbara Johnson 2023-05-17 15:57:30 UTC
Created attachment 151346 [details]
Display after suggested tweaks
Comment 12 Barbara Johnson 2023-05-17 15:57:49 UTC
Created attachment 151347 [details]
Missing edit_item_form
Comment 13 Lucas Gass 2023-05-25 22:11:14 UTC Comment hidden (obsolete)
Comment 14 ByWater Sandboxes 2023-05-25 22:57:03 UTC
Created attachment 151714 [details] [review]
Bug 33748: Fix UI issue when importing records from a staged MARC file

This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets.

1. Apply patch
2. Set  MarcItemFieldsToOrder like this:

    homebranch: 975$a
    holdingbranch: 975$b
    itype: 975$y
    nonpublic_note: 975$x
    public_note: 975$z
    loc: 975$c
    ccode: 975$8
    notforloan: 975$7
    quantity: 975$q
    price: 975$g
    replacementprice: 975$v
    uri: 975$u

3. Stage a MARC file where the bibs have items attached
4. From acquisitions create a new basket and add 'From a staged file'.
5. Add the staged files to a basket.
6. Make sure the display looks correct.
7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'.
8. Make sure the display looks correct.
9. Tab over to 'Item informtion' and make sure that display looks correct.
10. Shrink the screen size down to less that 992px, ensuring the display remains correct.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 15 Jonathan Druart 2023-06-01 07:33:07 UTC
Created attachment 151896 [details] [review]
Bug 33748: Fix UI issue when importing records from a staged MARC file

This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets.

1. Apply patch
2. Set  MarcItemFieldsToOrder like this:

    homebranch: 975$a
    holdingbranch: 975$b
    itype: 975$y
    nonpublic_note: 975$x
    public_note: 975$z
    loc: 975$c
    ccode: 975$8
    notforloan: 975$7
    quantity: 975$q
    price: 975$g
    replacementprice: 975$v
    uri: 975$u

3. Stage a MARC file where the bibs have items attached
4. From acquisitions create a new basket and add 'From a staged file'.
5. Add the staged files to a basket.
6. Make sure the display looks correct.
7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'.
8. Make sure the display looks correct.
9. Tab over to 'Item informtion' and make sure that display looks correct.
10. Shrink the screen size down to less that 992px, ensuring the display remains correct.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Tomás Cohen Arazi 2023-06-05 17:37:15 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Tomás Cohen Arazi 2023-06-09 14:07:55 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 18 Matt Blenkinsop 2023-06-12 10:15:12 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x