Bug 33759 - Typo: Thankyou
Summary: Typo: Thankyou
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 31028
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-18 09:15 UTC by Katrin Fischer
Modified: 2024-01-20 11:10 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04
Circulation function:

Attachments
Bug 33759: Fix typo 'Thankyou' in sample notices (2.13 KB, patch)
2023-08-11 08:36 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 33759: Fix typo 'Thankyou' in sample notices (2.19 KB, patch)
2023-08-11 11:32 UTC, Alexander Wagner 		Details | Diff | Splinter Review
Bug 33759: Fix typo 'Thankyou' in sample notices (2.29 KB, patch)
2023-08-25 09:22 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-18 09:15:55 UTC 
There are several notices reading 'Thankyou' we can fix to read "Thank you".
Comment 1 Katrin Fischer 2023-05-18 09:33:48 UTC 
Maybe also needs a database update?
Comment 2 Katrin Fischer 2023-08-11 08:36:05 UTC 
Created attachment 154358 [details] [review]
Bug 33759: Fix typo 'Thankyou' in sample notices

This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results
Comment 3 Alexander Wagner 2023-08-11 11:32:04 UTC 
Created attachment 154360 [details] [review]
Bug 33759: Fix typo 'Thankyou' in sample notices

This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
Comment 4 Katrin Fischer 2023-08-14 19:24:20 UTC 
Thanks, Alexander!
Comment 5 Marcel de Rooy 2023-08-25 09:22:47 UTC 
Created attachment 154789 [details] [review]
Bug 33759: Fix typo 'Thankyou' in sample notices

This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results

Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-08-29 17:36:11 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-08-30 06:49:05 UTC 
Pushed to 23.05.x for 23.05.04
Comment 8 Matt Blenkinsop 2023-08-31 10:07:36 UTC 
Depends on 31028 which is not in 22.11.x - not backporting

Nice work everyone!
Comment 9 Katrin Fischer 2024-01-20 11:10:40 UTC 
*** Bug 35853 has been marked as a duplicate of this bug. ***