Bug 33774 - Loading club table in every tab in patron details
Summary: Loading club table in every tab in patron details
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 26598
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-18 19:13 UTC by Caroline Cyr La Rose
Modified: 2023-06-08 17:04 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 33774: Loading club table in every tab in patron details (1.37 KB, patch)
2023-05-19 11:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33774: Loading club table in every tab in patron details (1.42 KB, patch)
2023-05-19 11:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 33774: Loading club table in every tab in patron details (1.53 KB, patch)
2023-05-20 02:00 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 33774: Loading club table in every tab in patron details (1.48 KB, patch)
2023-05-20 02:02 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-05-18 19:13:57 UTC
When clubs are defined, the clubs table loads in all tabs at the bottom of the patrons details page.

To recreate:
1. Create a club
   1.1. Go to Tools > Patron clubs
   1.2. Click 'New club template'
   1.3. Enter a name
   1.4. Click 'Save'
   1.5. Click 'New club' and choose the template
   1.6. Enter a name
   1.7. Click 'Save'

2. Go to Patrons and go in any patron's account
   --> At the bottom of the page, the 'Checkouts' tab says 'Loading...'

3. Click any other tab in that bottom section (Holds, Claims, Restrictions, Article requests, Recalls)
   --> All say 'Loading...'

4. Click the Clubs tab
   --> The table loads finally

5. Click back in any other tab
   --> The Clubs table shows in all tabs https://snipboard.io/0tBYLM.jpg
Comment 1 David Nind 2023-05-18 19:30:39 UTC
I checked this on 22.11.05, and it is not doing this.

So, at the moment the bug is limited to master.

I changed the importance to major, as the details area is used frequently - and I don't think you would want this bug showing in a new release.
Comment 2 Owen Leonard 2023-05-19 11:11:32 UTC
Git bisect says the problem comes from Bug 26598 Display guarantee's fines on guarantor's details page
Comment 3 Owen Leonard 2023-05-19 11:42:46 UTC
Created attachment 151470 [details] [review]
Bug 33774: Loading club table in every tab in patron details

This patch corrects a minor regression in template markup caused by Bug
33774. The Bootstrap tab attributes were lost (presumably in a merge)
causing the whole tab structure to break.

To test, you should have at least one club defined.

Apply the patch and view the patron details page. Each tab should load
its contents correctly.
Comment 4 David Nind 2023-05-19 11:53:47 UTC
Created attachment 151472 [details] [review]
Bug 33774: Loading club table in every tab in patron details

This patch corrects a minor regression in template markup caused by Bug
33774. The Bootstrap tab attributes were lost (presumably in a merge)
causing the whole tab structure to break.

To test, you should have at least one club defined.

Apply the patch and view the patron details page. Each tab should load
its contents correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Victor Grousset/tuxayo 2023-05-20 02:00:06 UTC Comment hidden (obsolete)
Comment 6 Victor Grousset/tuxayo 2023-05-20 02:02:20 UTC
Created attachment 151501 [details] [review]
Bug 33774: Loading club table in every tab in patron details

This patch corrects a minor regression in template markup caused by Bug
33774. The Bootstrap tab attributes were lost (presumably in a merge)
causing the whole tab structure to break.

To test, you should have at least one club defined.

Apply the patch and view the patron details page. Each tab should load
its contents correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2023-05-20 02:03:21 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 8 Tomás Cohen Arazi 2023-05-22 17:46:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-06-08 17:04:54 UTC
Missing dependency - not backporting to 22.11.x