When clubs are defined, the clubs table loads in all tabs at the bottom of the patrons details page. To recreate: 1. Create a club 1.1. Go to Tools > Patron clubs 1.2. Click 'New club template' 1.3. Enter a name 1.4. Click 'Save' 1.5. Click 'New club' and choose the template 1.6. Enter a name 1.7. Click 'Save' 2. Go to Patrons and go in any patron's account --> At the bottom of the page, the 'Checkouts' tab says 'Loading...' 3. Click any other tab in that bottom section (Holds, Claims, Restrictions, Article requests, Recalls) --> All say 'Loading...' 4. Click the Clubs tab --> The table loads finally 5. Click back in any other tab --> The Clubs table shows in all tabs https://snipboard.io/0tBYLM.jpg
I checked this on 22.11.05, and it is not doing this. So, at the moment the bug is limited to master. I changed the importance to major, as the details area is used frequently - and I don't think you would want this bug showing in a new release.
Git bisect says the problem comes from Bug 26598 Display guarantee's fines on guarantor's details page
Created attachment 151470 [details] [review] Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly.
Created attachment 151472 [details] [review] Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 151500 [details] [review] Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> https://bugs.koha-community.org/show_bug.cgi?id=26598
Created attachment 151501 [details] [review] Bug 33774: Loading club table in every tab in patron details This patch corrects a minor regression in template markup caused by Bug 33774. The Bootstrap tab attributes were lost (presumably in a merge) causing the whole tab structure to break. To test, you should have at least one club defined. Apply the patch and view the patron details page. Each tab should load its contents correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.05. Nice work everyone, thanks!
Missing dependency - not backporting to 22.11.x