Bug 33781 - Terminology: Item already issued to other borrower.
Summary: Terminology: Item already issued to other borrower.
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-05-19 08:19 UTC by Katrin Fischer
Modified: 2023-12-28 20:47 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33781: Terminology: Item already issued to other borrower. (2.47 KB, patch)
2023-05-25 13:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33781: Terminology: Item already issued to other borrower. (2.47 KB, patch)
2023-05-25 16:44 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33781: Terminology: Item already issued to other borrower. (2.53 KB, patch)
2023-07-07 11:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-19 08:19:41 UTC
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:156
Item already issued to other borrower.

issued should be "checked out"
Comment 1 Owen Leonard 2023-05-25 13:40:59 UTC
Created attachment 151683 [details] [review]
Bug 33781: Terminology: Item already issued to other borrower.

This patch updates a couple of error message strings so that they use
the correct terminology and read well.

"This item is on hold for another borrower." becomes "This item is on
hold for another patron."

"Item already issued to other borrower." becomes "This item is already
checked out to another patron."

To test, apply the patch and log into the OPAC as a patron who has items
checked out which are available for renewal.

In another tab, place a hold on one of those items on behalf of a
different patron.

Back in your OPAC tab, click the "Renew" link next to the title which is
now on hold. The page should reload and show the updated message, "This
item is on hold..."

I was not able to trigger the other message.
Comment 2 Lucas Gass 2023-05-25 16:44:37 UTC
Created attachment 151702 [details] [review]
Bug 33781: Terminology: Item already issued to other borrower.

This patch updates a couple of error message strings so that they use
the correct terminology and read well.

"This item is on hold for another borrower." becomes "This item is on
hold for another patron."

"Item already issued to other borrower." becomes "This item is already
checked out to another patron."

To test, apply the patch and log into the OPAC as a patron who has items
checked out which are available for renewal.

In another tab, place a hold on one of those items on behalf of a
different patron.

Back in your OPAC tab, click the "Renew" link next to the title which is
now on hold. The page should reload and show the updated message, "This
item is on hold..."

I was not able to trigger the other message.
Comment 3 Katrin Fischer 2023-07-07 11:24:31 UTC
Created attachment 153155 [details] [review]
Bug 33781: Terminology: Item already issued to other borrower.

This patch updates a couple of error message strings so that they use
the correct terminology and read well.

"This item is on hold for another borrower." becomes "This item is on
hold for another patron."

"Item already issued to other borrower." becomes "This item is already
checked out to another patron."

To test, apply the patch and log into the OPAC as a patron who has items
checked out which are available for renewal.

In another tab, place a hold on one of those items on behalf of a
different patron.

Back in your OPAC tab, click the "Renew" link next to the title which is
now on hold. The page should reload and show the updated message, "This
item is on hold..."

I was not able to trigger the other message.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi 2023-07-07 12:18:43 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 09:11:54 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-18 13:46:21 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x