Bug 33787 - Remove option to archive system debit types
Summary: Remove option to archive system debit types
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 32450
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-19 17:34 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Circulation function:

Attachments
Bug 33787: Fix for regression caused by bug 32450 (2.67 KB, patch)
2023-05-22 08:46 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33787: Fix for regression caused by bug 32450 (2.77 KB, patch)
2023-05-22 11:47 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-05-19 17:34:30 UTC 
It should not be possible to archive system debit types (such as ACCOUNT, OVERDUE, RENT, etc).

Only the manual types should have that option.

To recreate:
1. Go to Administration > Debit types
2. Click Show all debit types
   --> Note that *all* debit types have both the Edit and Archive buttons

Possibly a regression from bug 32450
Comment 1 Caroline Cyr La Rose 2023-05-19 17:37:22 UTC 
I tried Martin's fix 
https://gitlab.com/mrenvoize/Koha/-/commit/824e4220c712b2a9de9e5666216f6d853889d46f

And it works. Ready to sign-off :)
Comment 2 Martin Renvoize (ashimema) 2023-05-22 08:46:30 UTC 
Created attachment 151505 [details] [review]
Bug 33787: Fix for regression caused by bug 32450

This patch fixes the regression cashed by bug 32450 where we
accidentally introduced the option to archive system debit types.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Martin Renvoize (ashimema) 2023-05-22 08:47:00 UTC 
Thanks for spotting this, reporting it and then testing the fix Caroline :)
Comment 4 Marcel de Rooy 2023-05-22 11:47:03 UTC 
Created attachment 151512 [details] [review]
Bug 33787: Fix for regression caused by bug 32450

This patch fixes the regression cashed by bug 32450 where we
accidentally introduced the option to archive system debit types.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-22 17:46:17 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-08 17:09:36 UTC 
Nice work everyone!

Pushed to stable for 22.11.x