Created attachment 151559 [details] [review] Bug 33804: Add as_due_date option to $date
Created attachment 151560 [details] [review] Bug 33804: Use as_due_date to display due dates
Still working on this. We should pass no_tz_adjust to tell dayjs to not adjust the date. We want to display the value from the DB (otherwise 23:59 will be displayed 21:59). We don't deal with datetime correctly, hence the confusion everywhere...
Created attachment 151561 [details] [review] Bug 33804: Use as_due_date to display due dates
See bug 33568 for another example, where we don't need no_tz_adjust. The value is coming from the REST API.
I think this is working correctly, but it seems that we could clean and remove some of the columns in checkouts.js (so maybe move the second patch to its own bug report).
Test plan: Confirm that the datetimes are correctly displayed on the checkouts table Apply 33568 (or use the remote branch) Confirm that the datetimes are correct on the items table (you need checked out items, with and without the time part 23:59)
Created attachment 151666 [details] [review] Bug 33804: Add as_due_date option to $date Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151667 [details] [review] Bug 33804: Use as_due_date to display due dates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151668 [details] [review] Bug 33804: (follow-up) Convert to JSDoc formatted documentation
Our date handling still confuses me.. but I think this all appears to be correct. Signing off
This feels like an enh? Am I correct?
(In reply to Marcel de Rooy from comment #12) > This feels like an enh? Am I correct? Yes, adjusted.
Created attachment 153418 [details] [review] Bug 33804: Add as_due_date option to $date Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 153419 [details] [review] Bug 33804: Use as_due_date to display due dates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 153420 [details] [review] Bug 33804: (follow-up) Convert to JSDoc formatted documentation Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Not required for anything in 23.05.x series as yet.. leaving the door open for a future backport as required but not backporting for now.