Bug 33852 - jobs.t is not testing only_current
Summary: jobs.t is not testing only_current
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33556
  Show dependency treegraph
 
Reported: 2023-05-29 13:29 UTC by Tomás Cohen Arazi
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33852: Make jobs.t test the only_current parameter (1.14 KB, patch)
2023-05-29 13:33 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 33852: Make jobs.t test the only_current parameter (1.18 KB, patch)
2023-05-30 18:21 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33852: Make jobs.t test the only_current parameter (1.25 KB, patch)
2023-06-08 12:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33852: Add one more test (1.96 KB, patch)
2023-06-08 12:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-05-29 13:29:43 UTC
This test is not covering that parameter behaviour.
Comment 1 Tomás Cohen Arazi 2023-05-29 13:33:24 UTC
Created attachment 151774 [details] [review]
Bug 33852: Make jobs.t test the only_current parameter

This trivial patch adds a test to the only_current parameter.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/jobs.t
=> SUCCESS: New tests added, and pass
3. Sign off :-D
Comment 2 Sam Lau 2023-05-30 18:21:51 UTC
Created attachment 151822 [details] [review]
Bug 33852: Make jobs.t test the only_current parameter

This trivial patch adds a test to the only_current parameter.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/jobs.t
=> SUCCESS: New tests added, and pass
3. Sign off :-D

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Jonathan Druart 2023-06-08 12:35:16 UTC
Created attachment 152182 [details] [review]
Bug 33852: Make jobs.t test the only_current parameter

This trivial patch adds a test to the only_current parameter.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/jobs.t
=> SUCCESS: New tests added, and pass
3. Sign off :-D

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-06-08 12:35:18 UTC
Created attachment 152183 [details] [review]
Bug 33852: Add one more test

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-06-08 15:28:25 UTC
(In reply to Jonathan Druart from comment #4)
> Created attachment 152183 [details] [review] [review]
> Bug 33852: Add one more test
> 
> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Ok. I did it too quick :-D
Comment 6 Tomás Cohen Arazi 2023-06-09 11:27:56 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-12 07:20:37 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 8 Matt Blenkinsop 2023-07-12 09:36:16 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x