Bug 33855 - Clean up forms and page sections on 'manage MARC imports' page
Summary: Clean up forms and page sections on 'manage MARC imports' page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-29 14:04 UTC by Katrin Fischer
Modified: 2023-09-29 11:59 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement makes minor changes to the structure of the "Manage staged MARC records" page for a batch so that sections are more clearly delineated and forms have the correct structure. It also shortens the new framework field labels and adds hints for clarification.
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page (7.07 KB, patch)
2023-05-30 13:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page (7.10 KB, patch)
2023-06-06 01:01 UTC, David Nind
Details | Diff | Splinter Review
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page (7.16 KB, patch)
2023-06-08 21:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-29 14:04:45 UTC
The new options for handling MARC frameworks are not inside a page section on the MARC import page. I think this page would need profit from some restructuring.
Comment 1 Owen Leonard 2023-05-30 13:25:09 UTC
Created attachment 151798 [details] [review]
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page

This patch makes minor changes to the structure of the "Manage MARC
imports" page so that sections are more clearly delineated and forms
have the correct structure.

The patch also shortens the new framework field labels and adds hints
for clarification.

To test, apply the patch and go to Cataloging -> Stage MARC records for
import.

- Import a batch of MARC records.
- Go to Cataloging -> Manage staged records.
- View the batch you just imported.
- You should see three sections:
  - A list of information about the batch
  - Options for changing the matching rules
  - Options for setting frameworks during import.
- Test that the form for applying different matching rules still works
  correctly.
  - Import a batch of records which contains matches (by, for example,
    exporting MARC records from Koha and then reimporting the same
    batch)
  - On the manage page for that batch try changing the matching rule
    applied, switching between "Do not look for matching records" and a
    matching rule which will catch the duplicate records.
- Test that your records are imported correctly according to the
  framework settings you select, both for new records and for replaced
  records.
Comment 2 David Nind 2023-06-06 01:01:31 UTC
Created attachment 152021 [details] [review]
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page

This patch makes minor changes to the structure of the "Manage MARC
imports" page so that sections are more clearly delineated and forms
have the correct structure.

The patch also shortens the new framework field labels and adds hints
for clarification.

To test, apply the patch and go to Cataloging -> Stage MARC records for
import.

- Import a batch of MARC records.
- Go to Cataloging -> Manage staged records.
- View the batch you just imported.
- You should see three sections:
  - A list of information about the batch
  - Options for changing the matching rules
  - Options for setting frameworks during import.
- Test that the form for applying different matching rules still works
  correctly.
  - Import a batch of records which contains matches (by, for example,
    exporting MARC records from Koha and then reimporting the same
    batch)
  - On the manage page for that batch try changing the matching rule
    applied, switching between "Do not look for matching records" and a
    matching rule which will catch the duplicate records.
- Test that your records are imported correctly according to the
  framework settings you select, both for new records and for replaced
  records.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-06-06 01:07:14 UTC
A nice update!

One thing I noticed (both before and after the patch was applied) was that the DIff view page background is all grey and aligned to th efar left of the page - maybe this needs the div background change made? Possibly a separate bug, or a follow-up if a change is warranted.
Comment 4 Katrin Fischer 2023-06-08 21:34:25 UTC
Created attachment 152222 [details] [review]
Bug 33855: Clean up forms and page sections on 'manage MARC imports' page

This patch makes minor changes to the structure of the "Manage MARC
imports" page so that sections are more clearly delineated and forms
have the correct structure.

The patch also shortens the new framework field labels and adds hints
for clarification.

To test, apply the patch and go to Cataloging -> Stage MARC records for
import.

- Import a batch of MARC records.
- Go to Cataloging -> Manage staged records.
- View the batch you just imported.
- You should see three sections:
  - A list of information about the batch
  - Options for changing the matching rules
  - Options for setting frameworks during import.
- Test that the form for applying different matching rules still works
  correctly.
  - Import a batch of records which contains matches (by, for example,
    exporting MARC records from Koha and then reimporting the same
    batch)
  - On the manage page for that batch try changing the matching rule
    applied, switching between "Do not look for matching records" and a
    matching rule which will catch the duplicate records.
- Test that your records are imported correctly according to the
  framework settings you select, both for new records and for replaced
  records.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-06-08 21:34:56 UTC
(In reply to David Nind from comment #3)
> A nice update!

Agreed :)
Comment 6 Tomás Cohen Arazi 2023-06-09 11:42:52 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-12 08:24:26 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 8 Matt Blenkinsop 2023-07-12 09:41:49 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 9 Owen Leonard 2023-09-29 11:59:34 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.