The new options for handling MARC frameworks are not inside a page section on the MARC import page. I think this page would need profit from some restructuring.
Created attachment 151798 [details] [review] Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records.
Created attachment 152021 [details] [review] Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records. Signed-off-by: David Nind <david@davidnind.com>
A nice update! One thing I noticed (both before and after the patch was applied) was that the DIff view page background is all grey and aligned to th efar left of the page - maybe this needs the div background change made? Possibly a separate bug, or a follow-up if a change is warranted.
Created attachment 152222 [details] [review] Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to David Nind from comment #3) > A nice update! Agreed :)
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.