The "Problem" header row label and the problems themselves are untranslatable as they are added in the inventory.pl file.
Created attachment 152078 [details] [review] Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan: Update po, translate the new strings, install the language, use it for the UI and confirm that the CSV generated has 'problem' column translated gulp po:update --lang LANG vim misc/translator/po/LANG-messages-js.po cd misc/translator; perl translate install LANG
Hm, might need a little work with my dependent patch (I see yours still has problem instead of Problem)
Patch doesn't apply currently. (In reply to Katrin Fischer from comment #2) > Hm, might need a little work with my dependent patch (I see yours still has > problem instead of Problem) I think this is the first problem. It also doesn't take into account bug 22135 and "shelved out of order" I think.
Created attachment 185828 [details] [review] Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan: Update po, translate the new strings, install the language, use it for the UI and confirm that the CSV generated has 'problem' column translated gulp po:update --lang LANG vim misc/translator/po/LANG-messages-js.po cd misc/translator; perl translate install LANG
Patch rebased for master Caution : I was not able to test it as I could not find how to generate the updated po files but I think this is due to my poor knowledge on how to do it. On KTD When I use `gulp po:update --lang fr-FR` It generates new .pot files and update some .po files but the new chains are not in the file. Might be something wrong but I can't figure out what.
Comment on attachment 185828 [details] [review] Bug 33856: Make inventory problems translatable Review of attachment 185828 [details] [review]: ----------------------------------------------------------------- ::: tools/inventory.pl @@ +489,4 @@ > if ( $error->{'ERR_BARCODE'} ) { > push @line, map { $_ eq 'barcode' ? $error->{'barcode'} : '' } @keys; > push @line, "barcode not found"; > + push @line, __("barcode not found"); I think you've got a typo there where you didn't delete the untranslated line.
According to the commit message on 8044, it looks like you need to run "./translate update LANG" I think to get the .po files updated.
Created attachment 185847 [details] [review] Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan (assuming KTD): 1- Update po misc/translator/translate update LANG (for example LANG="fr-FR") 2- translate the new strings vim misc/translator/po/LANG-messages-js.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install LANG --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with sysprefStaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2
Thank you David for your help ! I corrected the typo and updated the commit message to detail more the process. This time I was able to test the patch and I worked well for me.
I think the test plan was a bit off.. Revised Test plan (assuming KTD): 0 - Apply the patch and koha-plack --restart kohadev 1- Update po misc/translator/translate update fr-FR 2- translate the new strings vim misc/translator/po/fr-FR-messages.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install fr-FR --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with syspref StaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2
(In reply to Marion Durand from comment #9) > Thank you David for your help ! > > I corrected the typo and updated the commit message to detail more the > process. > > This time I was able to test the patch and I worked well for me. I'm going to say that you've marked this as Signed Off too in this case
Created attachment 186189 [details] [review] Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan (assuming KTD): 1- Update po misc/translator/translate update LANG (for example LANG="fr-FR") 2- translate the new strings vim misc/translator/po/LANG-messages-js.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install LANG --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with sysprefStaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2 Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Thank you David for your help ! I didn't actually signed it off because I wasn't sure if I could as I rebased the patch. Thanks for adding my signoff
(In reply to Marion Durand from comment #13) > Thank you David for your help ! > > I didn't actually signed it off because I wasn't sure if I could as I > rebased the patch. Thanks for adding my signoff Fair enough! Doesn't hurt to be cautious!
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed into 24.11.x for 24.11.08 nice work everyone
EDIT: 24.11.09