Bug 33856 - Inventory tool CSV export contains untranslatable strings
Summary: Inventory tool CSV export contains untranslatable strings
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 22135
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-29 15:55 UTC by Katrin Fischer
Modified: 2023-09-06 00:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 33856: Make inventory problems translatable (2.84 KB, patch)
2023-06-07 08:52 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-29 15:55:26 UTC 
The "Problem" header row label and the problems themselves are untranslatable as they are added in the inventory.pl file.
Comment 1 Jonathan Druart 2023-06-07 08:52:54 UTC 
Created attachment 152078 [details] [review]
Bug 33856: Make inventory problems translatable

We should make the inventory 'problem' column translatable.

Test plan:
Update po, translate the new strings, install the language, use it for
the UI and confirm that the CSV generated has 'problem' column translated

gulp po:update --lang LANG
vim misc/translator/po/LANG-messages-js.po
cd misc/translator; perl translate install LANG
Comment 2 Katrin Fischer 2023-06-08 08:34:27 UTC 
Hm, might need a little work with my dependent patch (I see yours still has problem instead of Problem)
Comment 3 David Cook 2023-09-06 00:01:48 UTC 
Patch doesn't apply currently.

(In reply to Katrin Fischer from comment #2)
> Hm, might need a little work with my dependent patch (I see yours still has
> problem instead of Problem)

I think this is the first problem.

It also doesn't take into account bug 22135 and "shelved out of order" I think.