When you import a staged MARC record file it triggers a JS error in the console: "Uncaught ReferenceError: submitBackgroundJob is not defined" It seems to be caused by the absence of the JS file background-job-progressbar.js, but the only outward problem seems to the error. Batches are being imported successfully.
Created attachment 151892 [details] [review] Bug 33865: (bug 27421 follow-up) Remove leftover Bug 27421 replaced the progress bar with job_progress.inc. The code related to the old progress bar has not been removed however. Moreover there was a JS error in the console: "Uncaught ReferenceError: submitBackgroundJob is not defined" Test plan: Stage a MARC record for import Import it Revert the import All should work correctly, without JS error in the console and with the progress bar displayed nicely during the staging step.
Created attachment 151914 [details] [review] Bug 33865: (bug 27421 follow-up) Remove leftover Bug 27421 replaced the progress bar with job_progress.inc. The code related to the old progress bar has not been removed however. Moreover there was a JS error in the console: "Uncaught ReferenceError: submitBackgroundJob is not defined" Test plan: Stage a MARC record for import Import it Revert the import All should work correctly, without JS error in the console and with the progress bar displayed nicely during the staging step. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 151934 [details] [review] Bug 33865: (bug 27421 follow-up) Remove leftover Bug 27421 replaced the progress bar with job_progress.inc. The code related to the old progress bar has not been removed however. Moreover there was a JS error in the console: "Uncaught ReferenceError: submitBackgroundJob is not defined" Test plan: Stage a MARC record for import Import it Revert the import All should work correctly, without JS error in the console and with the progress bar displayed nicely during the staging step. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to oldstable for 22.11.x