This patch will modify authorities templates so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Created attachment 152124 [details] [review] Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type.
Created attachment 152125 [details] [review] Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 154812 [details] [review] Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Only one little question, why the USE raw? --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt @@ -1,7 +1,12 @@ [% USE To %] +[% USE raw %] +[% PROCESS 'i18n.inc' %]
(In reply to Katrin Fischer from comment #4) > Only one little question, why the USE raw? > +[% USE raw %] > +[% PROCESS 'i18n.inc' %] Just a copy-paste error I think
(In reply to Owen Leonard from comment #5) > (In reply to Katrin Fischer from comment #4) > > Only one little question, why the USE raw? > > > +[% USE raw %] > > +[% PROCESS 'i18n.inc' %] > > Just a copy-paste error I think Could you provide a quick follow-up to remove that line?
Created attachment 154848 [details] [review] Bug 33910: (follow-up) Remove mistaken addition of 'USE raw'
Pushed to master for 23.11. Nice work everyone, thanks!
I choose to not backport to stable to avoid too much translation work