Bug 33914 - Improve translation of title tags: Course reserves
Summary: Improve translation of title tags: Course reserves
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency tree / graph
 
Reported: 2023-06-06 15:56 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 33914: Improve translation of title tags: Course reserves (8.26 KB, patch)
2023-06-12 19:50 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33914: Improve translation of title tags: Course reserves (8.30 KB, patch)
2023-08-29 10:12 UTC, David Nind 		Details | Diff | Splinter Review
Bug 33914: Improve translation of title tags: Course reserves (8.39 KB, patch)
2023-09-01 09:34 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 15:56:44 UTC 
This patch will modify course reserves templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-12 19:50:06 UTC 
Created attachment 152285 [details] [review]
Bug 33914: Improve translation of title tags: Course reserves

This patch updates course reserves templates so that title
tags can be more easily translated.

To test you should have the UseCourseReserves system preference enabled.
Apply the patch and confirm that the following course reserves
pages have the correct title tags:

- Course reserves
- New course
- Course details
- Edit course
- Add reserves (step 1 and 2)
- Batch add reserves (step 1 and 2)
- Batch remove reserves
- Invalid course (/cgi-bin/koha/course_reserves/course-details.pl?course_id=)
Comment 2 David Nind 2023-08-29 10:12:02 UTC 
Created attachment 154897 [details] [review]
Bug 33914: Improve translation of title tags: Course reserves

This patch updates course reserves templates so that title
tags can be more easily translated.

To test you should have the UseCourseReserves system preference enabled.
Apply the patch and confirm that the following course reserves
pages have the correct title tags:

- Course reserves
- New course
- Course details
- Edit course
- Add reserves (step 1 and 2)
- Batch add reserves (step 1 and 2)
- Batch remove reserves
- Invalid course (/cgi-bin/koha/course_reserves/course-details.pl?course_id=)

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2023-09-01 09:34:46 UTC 
Created attachment 155085 [details] [review]
Bug 33914: Improve translation of title tags: Course reserves

This patch updates course reserves templates so that title
tags can be more easily translated.

To test you should have the UseCourseReserves system preference enabled.
Apply the patch and confirm that the following course reserves
pages have the correct title tags:

- Course reserves
- New course
- Course details
- Edit course
- Add reserves (step 1 and 2)
- Batch add reserves (step 1 and 2)
- Batch remove reserves
- Invalid course (/cgi-bin/koha/course_reserves/course-details.pl?course_id=)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-01 14:10:27 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-08 05:48:14 UTC 
Not backported to 23.05.x