Bug 33925 - Improve translation of title tags: Serials
Summary: Improve translation of title tags: Serials
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:15 UTC by Owen Leonard
Modified: 2024-04-18 13:39 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33925: Improve translation of title tags: Serials (25.31 KB, patch)
2023-09-08 17:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33925: Improve translation of title tags: Serials (25.35 KB, patch)
2023-10-05 11:28 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33925: Improve translation of title tags: Serials (35.46 KB, patch)
2024-01-13 16:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33925: Improve translation of title tags: Serials (35.62 KB, patch)
2024-01-22 13:26 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33925: Improve translation of title tags: Serials (30.72 KB, patch)
2024-04-18 13:39 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:15:58 UTC
This patch will modify serials templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-08 17:44:39 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-10-05 11:28:20 UTC
Created attachment 156569 [details] [review]
Bug 33925: Improve translation of title tags: Serials

This patch updates serials templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers;
Adding "page-section" <div> where it was lacking.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Serials home
  - Serials search results
    - Subscription details
      - Subscription edit
        - Search for vendor
        - Search for bibliographic record
      - Subscription renew
      - Serial collection
      - Create and modify routing list
        - Preview routing list
          - View routing slip
      - Claims
      - Check expiration
      - With a subscription which has manual history enabled, click the
        "Edit history" link under the "Planning" tab.
     - Select multiple serial search results and batch edit
  - New subscription
  - Manage frequencies: Create and edit
  - Manage numbering patterns: Create and edit
Comment 3 David Nind 2023-11-04 20:17:47 UTC
Some minor changes required:

1. Serial collection - page title for edit serials has brackets with nothing in them: select a couple of editions and click on 'Edit serials' button, browser title page has "Serial edition () > [Serial name] > Serials > Koha (before patch this was "Serial edition [Serial name] > Serials > Koha").

2. Edit routing list - serial name not in italics for page title: italics used for serial name on other pages, such as the detail page, serial collection; before the patch, the serial name was in italics (Editing routing list for Serial title - with "Serial title" in italics).

3. Check expiration - select a result and click on renew selected subscriptions: pop up window browser title has a ">" at the start: > Serials > Koha (before the patch, the title was "Serials subscription renew > Koha").

4. Subscription history - serial name not in italics for page title: [Serial details page] > Planning > Manual history - Edit history.
Comment 4 Owen Leonard 2024-01-13 16:20:26 UTC
Created attachment 161016 [details] [review]
Bug 33925: Improve translation of title tags: Serials

This patch updates serials templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers;
Adding "page-section" <div> where it was lacking.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Serials home
  - Serials search results
    - Subscription details
      - Subscription edit
        - Search for vendor
        - Search for bibliographic record
      - Subscription renew
      - Serial collection
      - Create and modify routing list
        - Preview routing list
          - View routing slip
      - Claims
      - Check expiration
      - With a subscription which has manual history enabled, click the
        "Edit history" link under the "Planning" tab.
     - Select multiple serial search results and batch edit
  - New subscription
  - Manage frequencies: Create and edit
  - Manage numbering patterns: Create and edit
Comment 5 Loïc 2024-01-22 11:35:12 UTC
For "With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab." in the test plan the web page title is "Subscription history" and could maybe be "Edit subscription history".

It's just a possible edit but it's not blocking.
Comment 6 Biblibre Sandboxes 2024-01-22 13:26:42 UTC
Created attachment 161238 [details] [review]
Bug 33925: Improve translation of title tags: Serials

This patch updates serials templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers;
Adding "page-section" <div> where it was lacking.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Serials home
  - Serials search results
    - Subscription details
      - Subscription edit
        - Search for vendor
        - Search for bibliographic record
      - Subscription renew
      - Serial collection
      - Create and modify routing list
        - Preview routing list
          - View routing slip
      - Claims
      - Check expiration
      - With a subscription which has manual history enabled, click the
        "Edit history" link under the "Planning" tab.
     - Select multiple serial search results and batch edit
  - New subscription
  - Manage frequencies: Create and edit
  - Manage numbering patterns: Create and edit

Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr>
Comment 7 Owen Leonard 2024-04-18 13:39:40 UTC
Created attachment 165102 [details] [review]
Bug 33925: Improve translation of title tags: Serials

This patch updates serials templates so that title tags can be more
easily translated. Some templates have been updated for consistency as
well: Harmonizing page title, breaddrumb navigation, and page headers;
Adding "page-section" <div> where it was lacking.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Serials home
  - Serials search results
    - Subscription details
      - Subscription edit
        - Search for vendor
        - Search for bibliographic record
      - Subscription renew
      - Serial collection
      - Create and modify routing list
        - Preview routing list
          - View routing slip
      - Claims
      - Check expiration
      - With a subscription which has manual history enabled, click the
        "Edit history" link under the "Planning" tab.
     - Select multiple serial search results and batch edit
  - New subscription
  - Manage frequencies: Create and edit
  - Manage numbering patterns: Create and edit

Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr>