Bug 33939 - JavaScript needs to distinguish between order budgets and default budgets when adding to staged file form a basket
Summary: JavaScript needs to distinguish between order budgets and default budgets whe...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 22802
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-07 13:19 UTC by Nick Clemens (kidclamp)
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08,22.05.16


Attachments
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately (1.97 KB, patch)
2023-06-07 13:23 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately (2.03 KB, patch)
2023-06-24 17:34 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately (2.08 KB, patch)
2023-07-09 14:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-06-07 13:19:50 UTC
From bug 22802 comment 10:

> Add orders from MARC file 
> "show inactive funds" is not checked
> expand the order div to see the details
You see
  Fund: Select a fund (will use default if set)
> Check "show inactive funds"
You see
  Select a fund (will populate orders/items if set)
> Uncheck "show inactive funds"
You see
  Select a fund (will populate orders/items if set)
Comment 1 Nick Clemens (kidclamp) 2023-06-07 13:23:34 UTC
Created attachment 152106 [details] [review]
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately

The dropdowns have different hints after bug 22802. We need to preserve those when adding
or hiding inactive budgets

To test:
1 - Add some inactive budgets to Koha
2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket
3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab
4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets
5 - Confirm inactive budgets are correctly shown/hidden
Comment 2 Andrew Fuerste-Henry 2023-06-24 17:34:40 UTC
Created attachment 152658 [details] [review]
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately

The dropdowns have different hints after bug 22802. We need to preserve those when adding
or hiding inactive budgets

To test:
1 - Add some inactive budgets to Koha
2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket
3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab
4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets
5 - Confirm inactive budgets are correctly shown/hidden

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Katrin Fischer 2023-07-09 14:28:06 UTC
Created attachment 153223 [details] [review]
Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately

The dropdowns have different hints after bug 22802. We need to preserve those when adding
or hiding inactive budgets

To test:
1 - Add some inactive budgets to Koha
2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket
3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab
4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets
5 - Confirm inactive budgets are correctly shown/hidden

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-07-09 14:28:48 UTC
Took me a little to figure out, but then it was obvious.

Just a thought... can we please unify the fund pull downs to the nice one we worked out for the receive page... pretty please?
Comment 5 Tomás Cohen Arazi 2023-07-14 18:24:08 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2023-07-18 11:52:11 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Matt Blenkinsop 2023-07-18 15:28:56 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 8 Lucas Gass 2023-09-13 20:31:20 UTC
Backported to 22.05.x for upcoming 22.05.16