From bug 22802 comment 10: > Add orders from MARC file > "show inactive funds" is not checked > expand the order div to see the details You see Fund: Select a fund (will use default if set) > Check "show inactive funds" You see Select a fund (will populate orders/items if set) > Uncheck "show inactive funds" You see Select a fund (will populate orders/items if set)
Created attachment 152106 [details] [review] Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden
Created attachment 152658 [details] [review] Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 153223 [details] [review] Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Took me a little to figure out, but then it was obvious. Just a thought... can we please unify the fund pull downs to the nice one we worked out for the receive page... pretty please?
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
Backported to 22.05.x for upcoming 22.05.16