Bug 33941 - EBSCO Packages filter failing
Summary: EBSCO Packages filter failing
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on: 32932
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-07 16:09 UTC by Matt Blenkinsop
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33941: Fix wrong URL name in EBSCOPackagesList (1.51 KB, patch)
2023-06-07 16:10 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33941: Fix wrong URL name in EBSCOPackagesList (1.56 KB, patch)
2023-06-08 07:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-06-07 16:09:58 UTC
A bug has been introduced in bug 32932 where the router is pointing to the wrong URL in EBSCO Packages when filtering the table
Comment 1 Matt Blenkinsop 2023-06-07 16:10:57 UTC
Created attachment 152119 [details] [review]
Bug 33941: Fix wrong URL name in EBSCOPackagesList

This patch fixes a URL pointing to the wrong route which stops filtering from working in the table.

Note: To test you will need some EBSCO credentials

Test plan:
1) In ERM, go to EBSCO > Packages and search for a package
2) It should fail with a warning in the console saying that a required param "package_id" is missing
3) Apply patch
4) Repeat step 1
5) It should now successfully fetch packages
Comment 2 Jonathan Druart 2023-06-08 07:08:08 UTC
Created attachment 152139 [details] [review]
Bug 33941: Fix wrong URL name in EBSCOPackagesList

This patch fixes a URL pointing to the wrong route which stops filtering from working in the table.

Note: To test you will need some EBSCO credentials

Test plan:
1) In ERM, go to EBSCO > Packages and search for a package
2) It should fail with a warning in the console saying that a required param "package_id" is missing
3) Apply patch
4) Repeat step 1
5) It should now successfully fetch packages

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Tomás Cohen Arazi 2023-06-08 11:33:34 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 4 Martin Renvoize 2023-07-12 07:01:54 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 5 Matt Blenkinsop 2023-07-12 09:17:04 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x