Bug 33968 - Two colons missing on guarantor labels in memberentry.pl form
Summary: Two colons missing on guarantor labels in memberentry.pl form
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-09 08:52 UTC by Sally
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33968: Add missing colons to guarantor related labels (4.30 KB, patch)
2023-06-09 09:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33968: Add missing colons to guarantor related labels (4.37 KB, patch)
2023-06-09 14:30 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sally 2023-06-09 08:52:39 UTC
On the joining/edit patron form, every label has colons at the end - except for the Patron guarantor section.

To view:

- Edit a child patron
- Under Patron guarantor, note the following two labels do not have colons:

1)  Show checkouts to guarantors
2)  Show fines to guarantors

I realise this is a ridiculously trivial bug, but it'd be nice to make it consistent.
Comment 1 Katrin Fischer 2023-06-09 09:50:59 UTC
Created attachment 152233 [details] [review]
Bug 33968: Add missing colons to guarantor related labels

Fixes some inconsistencies with the labels on the
patron detail page and patron edit form.

To test:
* Activate AllowStaffToSetCheckoutsVisibilityForGuarantor
  and AllowStaffToSetFinesVisibilityForGuarantor system
  preferences
* Link a patron to a guarantor
* Verify on the details tab the options for showing fines
  and checkouts show and are missing colons on the label
* Edit the patorn and verify the same is true for the form
* Apply patch
* Verify missing colons have been added :)
Comment 2 PTFS Europe Sandboxes 2023-06-09 14:30:02 UTC
Created attachment 152253 [details] [review]
Bug 33968: Add missing colons to guarantor related labels

Fixes some inconsistencies with the labels on the
patron detail page and patron edit form.

To test:
* Activate AllowStaffToSetCheckoutsVisibilityForGuarantor
  and AllowStaffToSetFinesVisibilityForGuarantor system
  preferences
* Link a patron to a guarantor
* Verify on the details tab the options for showing fines
  and checkouts show and are missing colons on the label
* Edit the patorn and verify the same is true for the form
* Apply patch
* Verify missing colons have been added :)

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-06-09 14:30:46 UTC
Thank you, Katrin!  I'll be able to delete my jQuery for this now :)
Comment 4 Katrin Fischer 2023-06-10 19:14:51 UTC
(In reply to Sally from comment #3)
> Thank you, Katrin!  I'll be able to delete my jQuery for this now :)

Thanks for reporting and testing :) I like consistency!
Comment 5 Katrin Fischer 2023-06-22 20:11:32 UTC
Nothing much to see here, but some punctuation. As the queue is very full I dare to PQA this.
Comment 6 Tomás Cohen Arazi 2023-06-23 14:03:56 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-17 14:03:04 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 8 Pedro Amorim 2023-07-18 11:54:43 UTC
Nice work everyone!

Pushed to 22.11.x for next release