I found this string while translating. It seems to be a string for screen readers only. But I think it should still follow terminology. The string is in opac-user.tt, around line 670. <caption class="sr-only">Relative issues</caption> It's for the tab that shows Relatives' checkouts.
Created attachment 152384 [details] [review] Bug 34015 - Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag.
Created attachment 152387 [details] [review] Bug 34015: Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 152586 [details] [review] Bug 34015: Terminology: Relative issues should be Relative's checkouts This patch changes the term 'issues' in a screen reader caption in the OPAC to the correct term 'checkouts'. To test: Setup: - Have a patron with a guarantee - Check out an item to the guarantee - Make sure the guarantee allows their guarantor to see their checkouts (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to be able to set this) 1. In the OPAC, log in with the guarantor patron 2. Click on the Relatives' checkouts tab 3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off) 4. Navigate to the table in the Relative's checkouts tab --> The screen reader should say 'Relative issue table with...' 5. Apply patch 6. Refresh the page 7. Restart the screen reader (if it was off) --> The screen reader should now say 'Relatives' checkouts table with...' Alternatively, open the page inspector and inspect the table, the caption is in the table tag, before the thead tag. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I tried to find other similar strings in the templates, but couldn't find any. Thx Caroline!
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release