Bug 34036 - Single receive doesn't reload data and order lines don't appear in received section
Summary: Single receive doesn't reload data and order lines don't appear in received s...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
: 34595 (view as bug list)
Depends on: 33784
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-16 13:05 UTC by Katrin Fischer
Modified: 2023-09-15 09:36 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04


Attachments
Bug 34036: Reload 'already received' table when edit modal closed (3.01 KB, patch)
2023-09-01 00:19 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34036: Reload 'already received' table when edit modal closed (3.06 KB, patch)
2023-09-01 07:57 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34036: Reload 'already received' table when edit modal closed (3.12 KB, patch)
2023-09-06 12:51 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-06-16 13:05:47 UTC
When you receive a single order line using the Receive link, the table appears with the order line still pending instead of it showing in the "Already received" section. When you manually reload the table, the order line moves.

To test:
* Create a basket and order line, close basket.
* Receive shipment, create invoice.
* Click on the receive link in the table of pending order lines.
* Fill out the form, especially the quantity received. Save.
* Verify the line still shows in the "pending orders" table, instead of the "Already received" area below.
* Reload page, order line now moves.

I believe we need to reload some data?
Comment 1 Katrin Fischer 2023-08-04 15:28:14 UTC
I just tested this again and it looks like the "Pending orders" table reloads, updating the Quantity if you do a partial receive, but the "Already received" table is not updated.
Comment 2 Katrin Fischer 2023-08-04 15:33:49 UTC
It looks like the "Already received" is not yet API driven, but in this case we need to force a page reload maybe?
Comment 3 Katrin Fischer 2023-08-04 15:36:58 UTC
... or make it API driven, but that's the harder fix.
Comment 4 Katrin Fischer 2023-08-23 12:53:20 UTC
*** Bug 34595 has been marked as a duplicate of this bug. ***
Comment 5 wainuiwitikapark 2023-08-25 00:33:42 UTC
(In reply to Katrin Fischer from comment #2)
> It looks like the "Already received" is not yet API driven, but in this case
> we need to force a page reload maybe?

I think this might be the best way to do it now yeah
Comment 6 Aleisha Amohia 2023-09-01 00:19:27 UTC
Created attachment 155049 [details] [review]
Bug 34036: Reload 'already received' table when edit modal closed

Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads.

To test:
1. Set up a vendor, budget, fund, and create a new basket.
2. Add two orders (two different records) to this basket.
3. Close the basket and go to receive the orders.
4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button
5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm
6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders.
7. Click Receive for the now pending order. Receive the item and Confirm.
8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders.

9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again.
10. Click Receive for the now pending order. Receive the item and Confirm.
11. The Already received table should reload so that both orders now show under Already received.
12. Click Cancel receipt for the order.
13. Click Receive for the now pending order, then Cancel without receiving the item.
14. Confirm the page loads as expected with one pending order and one already received order.

Sponsored-by: Toi Ohomai Institute of Technology
Comment 7 PTFS Europe Sandboxes 2023-09-01 07:57:38 UTC
Created attachment 155058 [details] [review]
Bug 34036: Reload 'already received' table when edit modal closed

Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads.

To test:
1. Set up a vendor, budget, fund, and create a new basket.
2. Add two orders (two different records) to this basket.
3. Close the basket and go to receive the orders.
4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button
5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm
6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders.
7. Click Receive for the now pending order. Receive the item and Confirm.
8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders.

9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again.
10. Click Receive for the now pending order. Receive the item and Confirm.
11. The Already received table should reload so that both orders now show under Already received.
12. Click Cancel receipt for the order.
13. Click Receive for the now pending order, then Cancel without receiving the item.
14. Confirm the page loads as expected with one pending order and one already received order.

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 8 Tomás Cohen Arazi 2023-09-06 12:51:28 UTC
Created attachment 155273 [details] [review]
Bug 34036: Reload 'already received' table when edit modal closed

Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads.

To test:
1. Set up a vendor, budget, fund, and create a new basket.
2. Add two orders (two different records) to this basket.
3. Close the basket and go to receive the orders.
4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button
5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm
6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders.
7. Click Receive for the now pending order. Receive the item and Confirm.
8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders.

9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again.
10. Click Receive for the now pending order. Receive the item and Confirm.
11. The Already received table should reload so that both orders now show under Already received.
12. Click Cancel receipt for the order.
13. Click Receive for the now pending order, then Cancel without receiving the item.
14. Confirm the page loads as expected with one pending order and one already received order.

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi 2023-09-06 12:57:56 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-09-08 19:16:21 UTC
Pushed to 23.05.x for 23.05.04
Comment 11 Matt Blenkinsop 2023-09-15 09:36:18 UTC
Missing dependencies in 22.11.x - not backporting

Nice work everyone!