Bug 34071 - Change the phrasing of 'automatic checkin' to fit consistent terminology
Summary: Change the phrasing of 'automatic checkin' to fit consistent terminology
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Sam Lau
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-20 19:38 UTC by Sam Lau
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:


Attachments
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology (2.10 KB, patch)
2023-06-21 18:07 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology (2.16 KB, patch)
2023-06-22 11:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology (2.21 KB, patch)
2023-06-22 22:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Lau 2023-06-20 19:38:15 UTC
Visit administration->item types and then edit an item. Notice there is a checkbox that is labeled as 'Automatic checkin', however 'checkin', in this case, is being utilized as a noun and according to the terminology (https://wiki.koha-community.org/wiki/Terminology#C), it should be written as 'Automatic check-in'
Comment 1 Sam Lau 2023-06-21 18:07:13 UTC
Created attachment 152537 [details] [review]
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology

This patch simply changes 'Automatic checkin' to be 'Automatic check-in'.

Test plan:
1) Go to administration -> item types and click the edit button on an item.
2) Notice there is a checkbox labeled 'Automatic checkin'.
3) Apply patch.
4) Refresh the page and notice the checkbox now says 'Automatic check-in'.
5) prove t/db_dependent/Koha/Checkouts.t
6) Sign-off :)
Comment 2 Owen Leonard 2023-06-22 11:26:04 UTC
Created attachment 152551 [details] [review]
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology

This patch simply changes 'Automatic checkin' to be 'Automatic
check-in'.

Test plan:
1) Go to administration -> item types and click the edit button on an
   item.
2) Notice there is a checkbox labeled 'Automatic checkin'.
3) Apply patch.
4) Refresh the page and notice the checkbox now says 'Automatic
   check-in'.
5) prove t/db_dependent/Koha/Checkouts.t
6) Sign-off :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2023-06-22 22:10:12 UTC
Created attachment 152606 [details] [review]
Bug 34071: Change the phrasing of 'automatic checkin' to fit consistent terminology

This patch simply changes 'Automatic checkin' to be 'Automatic
check-in'.

Test plan:
1) Go to administration -> item types and click the edit button on an
   item.
2) Notice there is a checkbox labeled 'Automatic checkin'.
3) Apply patch.
4) Refresh the page and notice the checkbox now says 'Automatic
   check-in'.
5) prove t/db_dependent/Koha/Checkouts.t
6) Sign-off :)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-23 13:02:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-17 14:03:19 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Pedro Amorim 2023-07-18 11:55:16 UTC
Nice work everyone!

Pushed to 22.11.x for next release