Bug 34102 - Remove unnecessary jQueryUI CSS in staff-global.scss
Summary: Remove unnecessary jQueryUI CSS in staff-global.scss
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-22 19:44 UTC by Lucas Gass
Modified: 2023-06-23 14:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 34102: Remove unesessary jQueryUI CSS (3.24 KB, patch)
2023-06-22 19:49 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-06-22 19:44:59 UTC
There is some leftover CSS related to JqueryUI that is no longer nessesary. I think we can safely remove it.
Comment 1 Lucas Gass 2023-06-22 19:49:00 UTC
Created attachment 152585 [details] [review]
Bug 34102: Remove unesessary jQueryUI CSS

To test:
1. Apply patch
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Nothing in the staff client should change, the CSS wasn't being used.
Comment 2 Owen Leonard 2023-06-23 14:27:27 UTC
We still depend on two jQueryUI features: Autocomplete and sortable. When those have been taken care of we should remove this CSS and all the jQueryUI files too.