There is still something wrong when searching by Name. Add agreements in this sequence: t b z They get sequential IDs (1 2 3 or similar). Now when you sort on the Name column, they won't sort by the description, but by their ID: zbt or tbz
Created attachment 152622 [details] [review] Bug 34107: Remove id from name column in erm list tables
Any test plan?
(In reply to Michal Denar from comment #2) > Any test plan? * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the "Name" column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba.
Then you are removing the ability to filter by id on the column (where we show it). The correct fix I think is to put the id after the name: - data: "me.agreement_id:me.name", + data: "me.name:me.agreement_id",
Created attachment 153008 [details] [review] Bug 34028: Show the secret when registering from the auth screen
Created attachment 153019 [details] [review] Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba.
(In reply to Jonathan Druart from comment #4) > Then you are removing the ability to filter by id on the column (where we > show it). > The correct fix I think is to put the id after the name: > > - data: "me.agreement_id:me.name", > + data: "me.name:me.agreement_id", You're right, thank you! I'm not sure we need the change on EHoldingsEBSCOPackagesList.vue though, it's not searchable or orderable.
Created attachment 153020 [details] [review] Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba.
This last patch removes the change from EHoldingsEBSCOPackagesList.vue (not needed, that column is not searchable or sortable). And also added the same behavior to EHoldingsLocalTitlesList.vue for consistency (was not possible to filter by id in titles list before, even though it shows, like other tables).
Created attachment 153052 [details] [review] Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x