Bug 34116 - Add page-sectioning to item search in label creator
Summary: Add page-sectioning to item search in label creator
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-23 15:19 UTC by Katrin Fischer
Modified: 2023-09-29 12:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34116: Add page-sectioning to item search in label creator (3.09 KB, patch)
2023-06-26 18:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34116: Add page-sectioning to item search in label creator (3.13 KB, patch)
2023-06-28 17:59 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34116: Add page-sectioning to item search in label creator (3.19 KB, patch)
2023-07-09 13:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-06-23 15:19:59 UTC
To test:
* Go to cataloguing > Label creator
* New > Label batch
* Link "Add items"
* Search for anything, like "e" in Title
* Verify the result list is missing page-sectioning (white background behind tables) 

In general this could be a good candidate for a little 'face lift' :)
Comment 1 Owen Leonard 2023-06-26 18:03:50 UTC
Created attachment 152702 [details] [review]
Bug 34116: Add page-sectioning to item search in label creator

This patch adds a "page-section" class to search results page seen when
adding items to a label batch. The patch also makes some minor changes
to markup around the search header to make it more consistent with other
search pages.

To test, apply the patch and go to Cataloging -> Label creator.

- Click New -> Label batch
- Without entering anything in the textarea, click the "Add item(s)"
  button"
- In the pop-up window, perform a search which will return multiple
  results.
- Confirm that everything looks correct and all controls work as they
  should.
Comment 2 Sam Lau 2023-06-28 17:59:32 UTC
Created attachment 152835 [details] [review]
Bug 34116: Add page-sectioning to item search in label creator

This patch adds a "page-section" class to search results page seen when
adding items to a label batch. The patch also makes some minor changes
to markup around the search header to make it more consistent with other
search pages.

To test, apply the patch and go to Cataloging -> Label creator.

- Click New -> Label batch
- Without entering anything in the textarea, click the "Add item(s)"
  button"
- In the pop-up window, perform a search which will return multiple
  results.
- Confirm that everything looks correct and all controls work as they
  should.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-07-09 13:04:29 UTC
Created attachment 153212 [details] [review]
Bug 34116: Add page-sectioning to item search in label creator

This patch adds a "page-section" class to search results page seen when
adding items to a label batch. The patch also makes some minor changes
to markup around the search header to make it more consistent with other
search pages.

To test, apply the patch and go to Cataloging -> Label creator.

- Click New -> Label batch
- Without entering anything in the textarea, click the "Add item(s)"
  button"
- In the pop-up window, perform a search which will return multiple
  results.
- Confirm that everything looks correct and all controls work as they
  should.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-07-10 18:43:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 09:33:38 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-18 14:07:17 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 7 Owen Leonard 2023-09-29 12:02:08 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.