To test: * Go to cataloguing > Label creator * New > Label batch * Link "Add items" * Search for anything, like "e" in Title * Verify the result list is missing page-sectioning (white background behind tables) In general this could be a good candidate for a little 'face lift' :)
Created attachment 152702 [details] [review] Bug 34116: Add page-sectioning to item search in label creator This patch adds a "page-section" class to search results page seen when adding items to a label batch. The patch also makes some minor changes to markup around the search header to make it more consistent with other search pages. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch - Without entering anything in the textarea, click the "Add item(s)" button" - In the pop-up window, perform a search which will return multiple results. - Confirm that everything looks correct and all controls work as they should.
Created attachment 152835 [details] [review] Bug 34116: Add page-sectioning to item search in label creator This patch adds a "page-section" class to search results page seen when adding items to a label batch. The patch also makes some minor changes to markup around the search header to make it more consistent with other search pages. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch - Without entering anything in the textarea, click the "Add item(s)" button" - In the pop-up window, perform a search which will return multiple results. - Confirm that everything looks correct and all controls work as they should. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153212 [details] [review] Bug 34116: Add page-sectioning to item search in label creator This patch adds a "page-section" class to search results page seen when adding items to a label batch. The patch also makes some minor changes to markup around the search header to make it more consistent with other search pages. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch - Without entering anything in the textarea, click the "Add item(s)" button" - In the pop-up window, perform a search which will return multiple results. - Confirm that everything looks correct and all controls work as they should. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.