Bug 34174 - Saving RIS results to Error 505
Summary: Saving RIS results to Error 505
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33341
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-30 14:33 UTC by Eugene Espinoza
Modified: 2023-12-02 10:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34174: (bug 33341 follow-up) Fix Ris export (1.30 KB, patch)
2023-07-05 14:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34174: (bug 33341 follow-up) Fix Ris export (1.35 KB, patch)
2023-07-05 14:58 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Espinoza 2023-06-30 14:33:27 UTC
When exporting records to RIS in the OPAC as well as in the administration panel, it results to Error 505.
In plack-opac-error-log, we are getting this error: 
[2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 166.
[2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 179.
[2023/06/30 22:30:04] [WARN] seek() on closed filehandle _GEN_51 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34.

Also in plack-intranet-error-log, when trying out to export to RIS a particular record:
[2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 84.
[2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 87.
[2023/06/30 22:29:21] [WARN] seek() on closed filehandle _GEN_38 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34.
Comment 1 Jonathan Druart 2023-07-05 14:47:11 UTC
Created attachment 153061 [details] [review]
Bug 34174: (bug 33341 follow-up) Fix Ris export

Bug 33341 incorrectly fix the perlcritic warning.
Comment 2 Tomás Cohen Arazi 2023-07-05 14:58:58 UTC
Created attachment 153062 [details] [review]
Bug 34174: (bug 33341 follow-up) Fix Ris export

Bug 33341 incorrectly fix the perlcritic warning.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2023-07-06 14:58:21 UTC
Trivial, PQA.
Comment 4 Tomás Cohen Arazi 2023-07-06 15:25:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Laura Escamilla 2023-07-12 15:29:45 UTC
(In reply to Tomás Cohen Arazi from comment #4)
> Pushed to master for 23.11.
> 
> Nice work everyone, thanks!


Can this be backported to 22.11.xx?
Comment 6 Katrin Fischer 2023-07-16 11:59:58 UTC
(In reply to Laura Escamilla from comment #5)
> (In reply to Tomás Cohen Arazi from comment #4)
> > Pushed to master for 23.11.
> > 
> > Nice work everyone, thanks!
> 
> 
> Can this be backported to 22.11.xx?

It needs to get into 23.05 first, then it can be considered. If you say the bug is in this version and as this is marked major it usually will be backported. Last decision is always up to RMaints.
Comment 7 Eugene Espinoza 2023-07-17 01:07:55 UTC
I confirm that this bug also persist in 22.11.xx.
Comment 8 Martin Renvoize 2023-07-17 15:44:55 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Matt Blenkinsop 2023-07-18 13:33:19 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 10 Eugene Espinoza 2023-12-02 10:00:23 UTC
Great work everyone!