When exporting records to RIS in the OPAC as well as in the administration panel, it results to Error 505. In plack-opac-error-log, we are getting this error: [2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 166. [2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 179. [2023/06/30 22:30:04] [WARN] seek() on closed filehandle _GEN_51 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. Also in plack-intranet-error-log, when trying out to export to RIS a particular record: [2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 84. [2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 87. [2023/06/30 22:29:21] [WARN] seek() on closed filehandle _GEN_38 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34.
Created attachment 153061 [details] [review] Bug 34174: (bug 33341 follow-up) Fix Ris export Bug 33341 incorrectly fix the perlcritic warning.
Created attachment 153062 [details] [review] Bug 34174: (bug 33341 follow-up) Fix Ris export Bug 33341 incorrectly fix the perlcritic warning. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Trivial, PQA.
Pushed to master for 23.11. Nice work everyone, thanks!
(In reply to Tomás Cohen Arazi from comment #4) > Pushed to master for 23.11. > > Nice work everyone, thanks! Can this be backported to 22.11.xx?
(In reply to Laura Escamilla from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > Pushed to master for 23.11. > > > > Nice work everyone, thanks! > > > Can this be backported to 22.11.xx? It needs to get into 23.05 first, then it can be considered. If you say the bug is in this version and as this is marked major it usually will be backported. Last decision is always up to RMaints.
I confirm that this bug also persist in 22.11.xx.
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
Great work everyone!