authorities-detail-modal.js has template variables in it: <img src=\"[% interface | html %]/[% theme | html %]/img/spinner-small.gif\" alt=\"\" /> We need to define variables in a Template Toolkit-processed file.
Created attachment 152918 [details] [review] Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console.
Created attachment 152919 [details] [review] Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 152979 [details] [review] Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying Since template variables cannot be processed by JS, we must use a template to declare a JS variable which the JS file can used. This patch corrects this problem in the JS file which handles display of the authority MARC preview from the authority search results page. To test, apply the patch and go to Authorities. - Perform a search which will return multiple authority results. - Click "Actions -> MARC preview." The preview should display correctly. - Click "Actions -> MARC preview" on another search result. This preview should also look correct. - There should be no JavaScript errors in the browser console. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial patch, resolves the issue.. no regressions spotted. Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x