See commit message from bug """ Note that the CSS is not correct yet. My understanding is that the DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column. """
Created attachment 153053 [details] [review] Bug 34201: Restore sorting indicator on ERM tables DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column Test plan: Create several agreements, notice that the list view is having the sorting indicators (blue arrows) in the top right of the first column. Sort the columns: asc, desc, combined sort (shift+click) and confirm that the indicators are correct
Don't forget to regenerate the CSS files: `yarn css:build`
Created attachment 153068 [details] [review] Bug 34201: Restore sorting indicator on ERM tables DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column Test plan: Create several agreements, notice that the list view is having the sorting indicators (blue arrows) in the top right of the first column. Sort the columns: asc, desc, combined sort (shift+click) and confirm that the indicators are correct Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153069 [details] [review] Bug 34201: (follow-up) Add additional specific CSS This patch adds more CSS to make sure this works in Vue and non-Vue pages. On non-Vue pages there are these three states: .sorting, .sorting_asc, .sorting_desc On the ERM page with Vue there is: .sorting, .sorting.sorting_asc, .sorting.sorting_desc This patch ensures all are covered.
Created attachment 153076 [details] [review] Bug 34201: (follow-up) Add additional specific CSS This patch adds more CSS to make sure this works in Vue and non-Vue pages. On non-Vue pages there are these three states: .sorting, .sorting_asc, .sorting_desc On the ERM page with Vue there is: .sorting, .sorting.sorting_asc, .sorting.sorting_desc This patch ensures all are covered. Signed-off-by: Sam Lau <samalau@gmail.com>
@QA: please confirm this second patch is really needed. Sorting indicators are correctly displayed on Vue and non-Vue DT tables without it for me.
Re-testing this today I find you're correct. My patch is not necessary.
Created attachment 153182 [details] [review] Bug 34201: Restore sorting indicator on ERM tables DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column Test plan: Create several agreements, notice that the list view is having the sorting indicators (blue arrows) in the top right of the first column. Sort the columns: asc, desc, combined sort (shift+click) and confirm that the indicators are correct Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x