To recreate: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order.
Created attachment 153203 [details] [review] Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected
Created attachment 153204 [details] [review] Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
I am only seeing the option to add the item to an item group when adding a new item, is that intended?
Created attachment 153304 [details] [review] Bug 34232: Make dropdown on additem page rescept display order To test: 1. EnableItemGroups 2. Find a record and add some new item groups with different display orders 3. Now edit an item on the record and scroll down to the dropdown underneath "+ Add to item group" 4. Notice that the values in the dropdown do not respect the display order. 5. Apply patch and restart_all 6. The display order should now be respected Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 153305 [details] [review] Bug 34232: (QA follow-up) Remove superfluous "Use:" from each list entry We do have a heading "Use existing item groups" above the entries. The added "Use:" in front of each entry is not requires and makes entries longer and harder to scan. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note: this is just one spot, we need to fix the others as well, like: Bug 34234 - Item groups dropdown in detail.tt modal does not respect display order
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
*** Bug 34234 has been marked as a duplicate of this bug. ***
If we are already on 22.11, are we supposed to be seeing this work correctly? It's not for us.
(In reply to Miranda Nero from comment #11) > If we are already on 22.11, are we supposed to be seeing this work > correctly? It's not for us. If you're on 22.11.08 or higher, then it should be working, but if you're on 22.11.07 or earlier, then it wouldn't be. Note that this fixes only the form for creating a new item - there's also bug 34234 (which hasn't been fixed yet) for the dialog box you get when adding an existing item to an item group.
Oh gotcha, thanks. I was looking at the drop down menu from that other bug.