Bug 34244 - Improve contrast in staff interface main page layered icons
Summary: Improve contrast in staff interface main page layered icons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-10 12:36 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:


Attachments
Bug 34244: Improve contrast in staff interface main page layered icons (1.39 KB, patch)
2023-07-10 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34244: Improve contrast in staff interface main page layered icons (1.43 KB, patch)
2023-07-10 14:34 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34244: Improve contrast in staff interface main page layered icons (1.49 KB, patch)
2023-07-10 21:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-10 12:36:41 UTC
The staff interface home page has layered Font Awesome icons for Advanced and Item search. The color of the "lower" icon was not updated during the staff interface redesign and now lacks sufficient contrast.
Comment 1 Owen Leonard 2023-07-10 13:10:01 UTC
Created attachment 153268 [details] [review]
Bug 34244: Improve contrast in staff interface main page layered icons

This patch adjusts CSS for the staff interface home page so that there
is better contrast with Font Awesome icons which are layered. The
main advanced search and item search links have two icons layered one on
top of the other, and the "lower" one needs to have better contrast
after the staff interface redesign.

To test, apply the patch and rebuild the staff interface CSS. Log into
the staff interface and confirm that the advanced search and item search
link icons are clear and distinguishable from each other.
Comment 2 Sam Lau 2023-07-10 14:34:17 UTC
Created attachment 153281 [details] [review]
Bug 34244: Improve contrast in staff interface main page layered icons

This patch adjusts CSS for the staff interface home page so that there
is better contrast with Font Awesome icons which are layered. The
main advanced search and item search links have two icons layered one on
top of the other, and the "lower" one needs to have better contrast
after the staff interface redesign.

To test, apply the patch and rebuild the staff interface CSS. Log into
the staff interface and confirm that the advanced search and item search
link icons are clear and distinguishable from each other.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-07-10 21:17:10 UTC
Created attachment 153300 [details] [review]
Bug 34244: Improve contrast in staff interface main page layered icons

This patch adjusts CSS for the staff interface home page so that there
is better contrast with Font Awesome icons which are layered. The
main advanced search and item search links have two icons layered one on
top of the other, and the "lower" one needs to have better contrast
after the staff interface redesign.

To test, apply the patch and rebuild the staff interface CSS. Log into
the staff interface and confirm that the advanced search and item search
link icons are clear and distinguishable from each other.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-07-10 21:17:37 UTC
Much nicer, thank you!
Comment 5 Tomás Cohen Arazi 2023-07-11 11:52:21 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Lauren Denny 2023-07-12 18:05:03 UTC
It would be nice if Koha could have an interface that makes the pages more accessible to individuals with disabilities.  I think most of it could be fixed with greater contrast in colors.  Here is a website that helps you evaluate your website to evaluate accessibility to individuals with disabilities:
https://wave.webaim.org/
Comment 7 Katrin Fischer 2023-07-12 18:08:23 UTC
(In reply to Lauren Denny from comment #6)
> It would be nice if Koha could have an interface that makes the pages more
> accessible to individuals with disabilities.  I think most of it could be
> fixed with greater contrast in colors.  Here is a website that helps you
> evaluate your website to evaluate accessibility to individuals with
> disabilities:
> https://wave.webaim.org/

We have made use of tools when looking at the colors of the new staff interface and already fixed some things. It would be helpful to fix more if we had individual bug reports for any issue you can identify.
Comment 8 Martin Renvoize 2023-07-18 10:08:46 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Matt Blenkinsop 2023-07-18 14:07:30 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 10 Owen Leonard 2023-09-29 11:46:24 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.