Bug 34271 - Remove a few Logger statements from REST API
Summary: Remove a few Logger statements from REST API
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 22678
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-13 14:02 UTC by Marcel de Rooy
Modified: 2023-11-13 14:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12


Attachments
Bug 34271: Remove a few Logger statements from REST API (3.27 KB, patch)
2023-07-13 14:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34271: Remove a few Logger statements from REST API (3.28 KB, patch)
2023-09-08 06:54 UTC, David Cook
Details | Diff | Splinter Review
Bug 34271: Remove a few Logger statements from REST API (3.35 KB, patch)
2023-10-17 12:32 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-07-13 14:02:29 UTC
See 22678
Comment 1 Marcel de Rooy 2023-07-13 14:27:46 UTC
Created attachment 153399 [details] [review]
Bug 34271: Remove a few Logger statements from REST API

See also bug 22678.
We should call app->log->warn, ->debug, etc. instead of Logger.

Test plan:
The simplest way I tested V1, is add a app->log->warn in the try
blocks, restart all and check that your log4perl is set correctly
too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-02 13:48:33 UTC
David, could you add your signoff here please?
Comment 3 David Cook 2023-09-08 06:53:19 UTC
Ok so I tested Koha/REST/V1.pm by manually adding "die" into the try blocks and I confirmed the logging change worked.

Koha/REST/V1/OAuth/Client.pm is a bit more elaborate, so I'm going to eyeball that one. The change to Koha/REST/V1.pom confirms that the syntax works correctly, so all good to me.
Comment 4 David Cook 2023-09-08 06:54:14 UTC
Created attachment 155359 [details] [review]
Bug 34271: Remove a few Logger statements from REST API

See also bug 22678.
We should call app->log->warn, ->debug, etc. instead of Logger.

Test plan:
The simplest way I tested V1, is add a app->log->warn in the try
blocks, restart all and check that your log4perl is set correctly
too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Martin Renvoize 2023-10-17 12:32:34 UTC
Created attachment 157236 [details] [review]
Bug 34271: Remove a few Logger statements from REST API

See also bug 22678.
We should call app->log->warn, ->debug, etc. instead of Logger.

Test plan:
The simplest way I tested V1, is add a app->log->warn in the try
blocks, restart all and check that your log4perl is set correctly
too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-10-17 12:33:05 UTC
Great to see this worked through, thanks.

No regressions found, QA scripts happy.

Passing QA
Comment 7 Tomás Cohen Arazi 2023-10-18 13:26:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-25 07:31:16 UTC
Pushed to 23.05.x for 23.05.05
Comment 9 Matt Blenkinsop 2023-11-13 14:03:19 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x