Bug 34282 - ILL batches - availability checking has issues
Summary: ILL batches - availability checking has issues
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
Depends on: 30719
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-14 15:42 UTC by Pedro Amorim
Modified: 2024-02-13 10:13 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 34282: Fix availability check in ILL batches (8.58 KB, patch)
2023-07-14 15:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34282: Follow-up to fix multiple requests causing high server load, squash later (6.16 KB, patch)
2023-07-17 15:57 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34282: Fix availability check in ILL batches (9.93 KB, patch)
2023-08-07 10:30 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34282: Fix availability check in ILL batches (10.04 KB, patch)
2023-08-07 16:13 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34282: Fix availability check in ILL batches (10.04 KB, patch)
2023-09-29 11:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34282: Fix availability check in ILL batches (10.10 KB, patch)
2023-12-15 17:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-07-14 15:42:42 UTC

    
Comment 1 Pedro Amorim 2023-07-14 15:47:19 UTC
Created attachment 153494 [details] [review]
Bug 34282: Fix availability check in ILL batches

Staging modal area had issues listing availability checks for each request in the batch creation process

To test:
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases
3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases
4) Enable ILLCheckAvailability sys pref
5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466
6) Verify that the availability results show and are working, for each request in the batch
Comment 2 Pedro Amorim 2023-07-17 15:57:35 UTC
Created attachment 153564 [details] [review]
Bug 34282: Follow-up to fix multiple requests causing high server load, squash later
Comment 3 Pedro Amorim 2023-08-07 10:30:51 UTC
Created attachment 154304 [details] [review]
Bug 34282: Fix availability check in ILL batches

Staging modal area had issues listing availability checks for each request in the batch creation process

To test:
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases
3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases
4) Enable ILLCheckAvailability sys pref
5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466
6) Verify that the availability results show and are working, for each request in the batch
Comment 4 Pedro Amorim 2023-08-07 16:13:03 UTC
Created attachment 154308 [details] [review]
Bug 34282: Fix availability check in ILL batches

Staging modal area had issues listing availability checks for each request in the batch creation process

To test:
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases
3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases
4) Enable ILLCheckAvailability sys pref
5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466
6) Verify that the availability results show and are working, for each request in the batch

Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk>

Sponsored-by: UKHSA (UK Health Security Agency)
Comment 5 Pedro Amorim 2023-09-29 11:38:49 UTC
Created attachment 156385 [details] [review]
Bug 34282: Fix availability check in ILL batches

Staging modal area had issues listing availability checks for each request in the batch creation process

To test:
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases
3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases
4) Enable ILLCheckAvailability sys pref
5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466
6) Verify that the availability results show and are working, for each request in the batch

Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk>

Sponsored-by: UKHSA (UK Health Security Agency)
Comment 6 Pedro Amorim 2023-09-29 11:40:01 UTC
Thanks for looking, Marcel.
This test plan requires EDS credentials, I can go through it with you if/when you you're available to look at this again.
Comment 7 Tomás Cohen Arazi 2023-12-15 17:49:49 UTC
Created attachment 159894 [details] [review]
Bug 34282: Fix availability check in ILL batches

Staging modal area had issues listing availability checks for each request in the batch creation process

To test:
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases
3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases
4) Enable ILLCheckAvailability sys pref
5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466
6) Verify that the availability results show and are working, for each request in the batch

Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk>

Sponsored-by: UKHSA (UK Health Security Agency)
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Katrin Fischer 2024-01-31 13:45:42 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-02-13 10:13:48 UTC
23.11.x is still young so I backport

Pushed to 23.11.x for 23.11.03