Bug 34325 - On the manual invoice and credit forms rename "Barcode" to "Item barcode" for clarity
Summary: On the manual invoice and credit forms rename "Barcode" to "Item barcode" for...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2023-07-20 14:16 UTC by Lisette Scheer
Modified: 2024-07-08 07:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement changes the form labels and error message for the manual invoice and credit forms for patrons (in the accounting section). This is to clarify that this field is for an item barcode, and not a patron card number barcode.
Version(s) released in:


Attachments
Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms (5.19 KB, patch)
2024-07-08 02:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms (5.21 KB, patch)
2024-07-08 02:53 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2023-07-20 14:16:19 UTC
It would be great if we could specify if a manual invoice debit type would show the barcode field.

Right now staff may be confused by the barcode field showing and not validating when doing new cards if they try to put a patron card in and also the message not being helpful that the barcode is invalid because it doesn't let us know that it's looking at items only. 

An alternative could be to make the "Barcode" field "Item Barcode"

Lisette
Comment 1 Katrin Fischer 2023-07-20 14:41:24 UTC
I think renaming the field to "Item barcode" sounds like a good idea.
Comment 2 David Nind 2024-07-08 02:42:19 UTC Comment hidden (obsolete)
Comment 3 David Nind 2024-07-08 02:52:15 UTC
I have only changed the manual invoice and credit forms to change "Barcode" to "Item barcode".

Note that:
1. The manual invoice form generates an error message if you enter a patron card number.
2. The manual credit form doesn't generate an error message - it is beyond my skills to add an error message to the manual credit form.
3. I have also left the table headings under transactions, details, and make a payment as "Barcode" - I think there is enough context to know that this is an item barcode.
Comment 4 David Nind 2024-07-08 02:53:24 UTC
Created attachment 168580 [details] [review]
Bug 34325: Rename "Barcode" to "Item barcode" on manual invoice and credit forms

The forms for adding a manual invoice and credit for patrons (in
the accounting section) have a field for entering a barcode. This
can cause confusion, as it is not clear if it is for an item
barcode or the patron card number.

This patch changes the form labels and error message for the
manual invoice and credit forms to clarify that this is for an
item barcode. Related table column headings are left as "Barcode".

Test plan:
1. Go to a patron's record: Patrons > search for a patron >
   select a patron.
2. Go to Accounting > Create manual invoice.
3. Note that there is a label "Barcode:"
4. Enter details for a manual invoice and 'Save':
   - Type: Manual fee
   - Barcode: an item barcode, for example 39999000011418
   - Amount: 15
   ==> Result: Manual invoice saved
5. Repeat step 4, but enter a patron card number for the barcode.
   For example: 23529000651225.
   ==> Result: You get an error message
               "Error: Invalid barcode entered, please try again".
6. Enter details for a manual credit and 'Save':
   - Credit type: Credit
   - Barcode: an item barcode, for example 39999000011418
   - Amount: 5
   ==> Result: Manual credit saved.
7. Check the tables listing transactions - note that the column
   heading is "Barcode". (Tables are Transactions, Make a payment,
   and Transactions > Details (under the Actions column).
8. Apply the patch.
9. Repeat steps 4 to 7. Note that:
   - The label is now "Item barcode:" for the manual invoice and
     manual credit forms.
   - The error message in step 5 is now "Error: Invalid item
     barcode entered, please try again".
   - For the tables in step 8, the column headings remain as
     "Barcode" - there is generally enough context that it doesn't
     need to be changed.
10. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2024-07-08 07:26:10 UTC
Nice one :)