Bug 34326 - Add forbidden notforloan status
Summary: Add forbidden notforloan status
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Thibaud Guillot (thibaud_g)
QA Contact: Testopia
URL:
Keywords: no-sandbox
Depends on:
Blocks:
 
Reported: 2023-07-20 14:54 UTC by Thibaud Guillot (thibaud_g)
Modified: 2024-04-27 08:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 34326: Add forbidden notforloan status option (3.43 KB, patch)
2023-07-21 07:45 UTC, Thibaud Guillot (thibaud_g)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot (thibaud_g) 2023-07-20 14:54:09 UTC
Hello everyone,

SIP allows you to manage item statuses, but it may be useful to add a list of statuses related to "notforloan" in order to specifically reject some of them.
Comment 1 Thibaud Guillot (thibaud_g) 2023-07-21 07:45:43 UTC
Created attachment 153756 [details] [review]
Bug 34326: Add forbidden notforloan status option

Test plan:

1) Add on your sip account an option called "forbidden_notforloan_status"
   and specify values separated by commas like "1,4,6" related to your
   notforloan statuses.
2) Restart your SIP server after that
3) Launch your SIP command on checkin with some items with these
   statuses. See the normal output
4) Apply this patch
5) Do step 3 again and see the new output with forbidden status and lib
   related to
Comment 2 Katrin Fischer 2023-07-21 08:14:06 UTC
Hi Thibad, can you explain this a bit more? Is it to prevent checkin of certain items on the self check?
Comment 3 Thibaud Guillot (thibaud_g) 2023-07-21 08:23:13 UTC
Hi Katrin,

Sorry maybe I pushed it a little bit quickly :)

It will add a special SIP option, to prevent the checkin of items if they have a special status. For example, if an item has the status "in treasury", we'd like to prevent it from being returned via SIP. So it's based on a customer case but I hope that you understand the way it would work
Comment 4 Emmanuel Bétemps 2024-02-09 07:09:40 UTC
Hi,

I'd like to test this patch but I only have access to sandboxes
Do you confirm that, with this condition, I can't test ?
Comment 5 David Nind 2024-04-26 20:24:43 UTC
Added the no-sandbox keyword, as you can't normally test SIP2 changes using the sandboxes.

Could you please provide some before and after examples for the SIP commands? 

For those of us not familiar with SIP2 commands, step-by-step instructions to walk through the commands are essential.

More for QA, but I think your patch needs a description, as per the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages
Comment 6 Emmanuel Bétemps 2024-04-27 08:21:33 UTC
(In reply to David Nind from comment #5)
> Added the no-sandbox keyword, as you can't normally test SIP2 changes using
> the sandboxes.


ok, thanks !