Bug 33940 will remove t/Members/cardnumber.t that APPEARS to use a feature of DBD::Mock, i.e. filling $dbh->{mock_add_resultset}. But since the module is not loaded there (since ages), the whole thing is not even working! Simple illustration. Suppose you have borrower 50. Run update cardnumber='123456789' where borrowernumber=50; Now run t/Members/cardnumber.t not ok 3 - 123456789 is shorter than 10 # Failed test '123456789 is shorter than 10' # at t/Members/cardnumber.t line 36. # got: '1' # expected: '2' What happened? Instead of using the mocked empty set, checkcardnumber finds your 123456789 cardnumber in the database. Deception !
(In reply to Marcel de Rooy from comment #0) > Run update cardnumber='123456789' where borrowernumber=50; update borrowers set cardnumber='123456789' where borrowernumber=50;
Created attachment 153896 [details] [review] Bug 34414: Remove DBD::Mock We never actually used it. See BZ report. Test plan: Run git grep DBD::Mock. Only finding old release notes. Run git grep mock_add_resultset. Nothing. Bonus: Find a few other DBD::Mock properties/attributes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA: NOTE the dependency
Created attachment 153897 [details] [review] Bug 34414: Remove DBD::Mock We never actually used it. See BZ report. Test plan: Run git grep DBD::Mock. Only finding old release notes. Run git grep mock_add_resultset. Nothing. Bonus: Find a few other DBD::Mock properties/attributes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Taking the liberty to move this to PQA. Trivial. Signed off by QA team member.
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 33940 not in 23.05.x