To recreate: 1. Have the default notices set for AUTO_RENEWALS and AUTO_RENEWALS_DGST. 2. Set the ItemsDeniedRenewal system preference. ( itemlost: [1,2,3,4,5] ) 3. Set the AutoRenewalNotices system preference to 'According to messaging preferences'. 4. Don't mark lost items as returned ( MarkLostItemsAsReturned ). 5. Set up some auto renewals and then mark the items as lost. 6. Run automatic_renewals.pl 7. You get a notice telling you the item cannot be renewed but no reason is specified.
This is causing our patrons to receive an auto renewal digest notice the day after their items are marked as long overdue, stating that the item can't be renewed. We don't want to send this notice, as it is could be confusing to patrons who just received a bill for those lost items.
Created attachment 179464 [details] [review] Bug 34498: Make autorenewal notices consider ItemsDeniedRenewal This fix ensures that autorenewals (and corresponding notices) are not generated for items that are configured to be denied renewal in the ItemsDeniedRenewal system preference. To test: 1. Have the default notices set for AUTO_RENEWALS and AUTO_RENEWALS_DGST. 2. Set the ItemsDeniedRenewal system preference. ( itemlost: [1,2,3,4,5] ) 3. Set the AutoRenewalNotices system preference to 'According to messaging preferences'. 4. Don't mark lost items as returned ( MarkLostItemsAsReturned ). 5. Set up some auto renewals and then mark the items as lost. 6. Run automatic_renewals.pl 7. You get a notice telling you the item cannot be renewed but no reason is specified. 8. Apply the patch and restart services 9. Run through the test plan again and confirm no notices are generated. Sponsored-by: New Zealand Parliamentary Library