Bug 34498 - Default autorenewal notices do not account for item_denied_renewal
Summary: Default autorenewal notices do not account for item_denied_renewal
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-08 16:36 UTC by Lucas Gass (lukeg)
Modified: 2025-03-19 02:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 34498: Make autorenewal notices consider ItemsDeniedRenewal (2.16 KB, patch)
2025-03-18 20:40 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-08-08 16:36:10 UTC
To recreate:

1. Have the default notices set for AUTO_RENEWALS and AUTO_RENEWALS_DGST.
2. Set the ItemsDeniedRenewal system preference. ( itemlost: [1,2,3,4,5] )
3. Set the AutoRenewalNotices system preference to 'According to messaging preferences'.
4. Don't mark lost items as returned (  MarkLostItemsAsReturned ).
5. Set up some auto renewals and then mark the items as lost. 
6. Run automatic_renewals.pl
7. You get a notice telling you the item cannot be renewed but no reason is specified.
Comment 1 Juliet Heltibridle 2024-12-06 19:01:19 UTC
This is causing our patrons to receive an auto renewal digest notice the day after their items are marked as long overdue, stating that the item can't be renewed. We don't want to send this notice, as it is could be confusing to patrons who just received a bill for those lost items.
Comment 2 Aleisha Amohia 2025-03-18 20:40:22 UTC
Created attachment 179464 [details] [review]
Bug 34498: Make autorenewal notices consider ItemsDeniedRenewal

This fix ensures that autorenewals (and corresponding notices) are not generated for items that are configured to be denied renewal in the ItemsDeniedRenewal system preference.

To test:

1. Have the default notices set for AUTO_RENEWALS and AUTO_RENEWALS_DGST.
2. Set the ItemsDeniedRenewal system preference. ( itemlost: [1,2,3,4,5] )
3. Set the AutoRenewalNotices system preference to 'According to messaging preferences'.
4. Don't mark lost items as returned (  MarkLostItemsAsReturned ).
5. Set up some auto renewals and then mark the items as lost.
6. Run automatic_renewals.pl
7. You get a notice telling you the item cannot be renewed but no reason is specified.

8. Apply the patch and restart services

9. Run through the test plan again and confirm no notices are generated.

Sponsored-by: New Zealand Parliamentary Library