There are no results when filtering "All payments to the library" or "payment", but other transaction types can filter and show results.
Dame problema in 22.11.08
(In reply to Claudio Costales from comment #1) > Dame problema in 22.11.08 Same problem in 22.11.08
Created attachment 154834 [details] [review] Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not
(In reply to Nick Clemens from comment #3) > Created attachment 154834 [details] [review] [review] > Bug 34552: Don't exclude payments with no status > > Bug 29664 removed payments with a void status, however, the query also > removed any payments with no status set > > Test Plan: > 1 - Set up your cash registers and enable POS and add a debit type that is > able to be sold > 2 - Take 2 payments via POS > 3 - Void one payment > 4 - Go to Reports->Statistics wizards->Cash register > 4) Verify neither shows for the "All payments to the library" and > "Payment" transaction type filters > 5) Apply this patch > 6) Restart all the things! > 7) Verify the non-voided fee shows for the "All payments to the library" and > "Payment" transaction type filters and the voided fee does not #### I already tested but it did not work..... The same issues still occur, with no result when filtering "All payments to the library" and "Payment"
Agree with Jimmy
Please don't use 'in discussion' unless there is one, if something doesn't work, pleaes use FQA.
Claudio and Jimmy, how did you test?
(In reply to Katrin Fischer from comment #7) > Claudio and Jimmy, how did you test? In a local installation, Katrin
(In reply to Claudio Costales from comment #8) > (In reply to Katrin Fischer from comment #7) > > Claudio and Jimmy, how did you test? > > In a local installation, Katrin Package installation or development/git installation? Asking because the patch itself makes sense to me and I wonder if maybe a missing Plack restart or similar could have been the culprit.
(In reply to Katrin Fischer from comment #9) > (In reply to Claudio Costales from comment #8) > > (In reply to Katrin Fischer from comment #7) > > > Claudio and Jimmy, how did you test? > > > > In a local installation, Katrin > > Package installation or development/git installation? Asking because the > patch itself makes sense to me and I wonder if maybe a missing Plack restart > or similar could have been the culprit. Package installation. Katrin, I followed your suggestion and it works (Restarted memcached and plack). Thanks for your patience.
Created attachment 155625 [details] [review] Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Works as described. Great job!
Created attachment 155756 [details] [review] Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Please backport to 22.11 if possible. Needed functionality.
Pushed to 23.05.x for 23.05.04
Is there any chance this can be backported into 22.11, please?
(In reply to Laura O'Neil from comment #17) > Is there any chance this can be backported into 22.11, please? +1
Nice work everyone! Pushed to oldstable for 22.11.x
(In reply to Matt Blenkinsop from comment #20) > Nice work everyone! > > Pushed to oldstable for 22.11.x Thank you! :)