Bug 34552 - No Results when filtering "All payments to the library" or "payment" in Statistics wizards : Cash register
Summary: No Results when filtering "All payments to the library" or "payment" in Stati...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All Linux
: P3 normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Katrin Fischer
URL:
Keywords: rel_22_11_candidate
Depends on: 29664
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-17 06:39 UTC by Jimmy
Modified: 2023-10-03 19:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34552: Don't exclude payments with no status (1.37 KB, patch)
2023-08-25 16:00 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 34552: Don't exclude payments with no status (1.43 KB, patch)
2023-09-14 16:48 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34552: Don't exclude payments with no status (1.48 KB, patch)
2023-09-17 13:31 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy 2023-08-17 06:39:01 UTC
There are no results when filtering "All payments to the library" or "payment", but other transaction types can filter and show results.
Comment 1 Claudio Costales 2023-08-23 17:09:10 UTC
Dame problema in 22.11.08
Comment 2 Claudio Costales 2023-08-23 17:11:10 UTC
(In reply to Claudio Costales from comment #1)
> Dame problema in 22.11.08

Same problem in 22.11.08
Comment 3 Nick Clemens (kidclamp) 2023-08-25 16:00:08 UTC
Created attachment 154834 [details] [review]
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not
Comment 4 Jimmy 2023-09-03 00:55:45 UTC
(In reply to Nick Clemens from comment #3)
> Created attachment 154834 [details] [review] [review]
> Bug 34552: Don't exclude payments with no status
> 
> Bug 29664 removed payments with a void status, however, the query also
> removed any payments with no status set
> 
> Test Plan:
> 1 - Set up your cash registers and enable POS and add a debit type that is
> able to be sold
> 2 - Take 2 payments via POS
> 3 - Void one payment
> 4 - Go to Reports->Statistics wizards->Cash register
> 4) Verify neither shows for the "All payments to the library" and
>    "Payment" transaction type filters
> 5) Apply this patch
> 6) Restart all the things!
> 7) Verify the non-voided fee shows for the "All payments to the library" and
>    "Payment" transaction type filters and the voided fee does not

#### I already tested but it did not work..... The same issues still occur, with no result when filtering "All payments to the library" and "Payment"
Comment 5 Claudio Costales 2023-09-05 00:21:27 UTC
Agree with Jimmy
Comment 6 Katrin Fischer 2023-09-05 06:23:12 UTC
Please don't use 'in discussion' unless there is one, if something doesn't work, pleaes use FQA.
Comment 7 Katrin Fischer 2023-09-05 07:33:16 UTC
Claudio and Jimmy, how did you test?
Comment 8 Claudio Costales 2023-09-05 10:17:21 UTC
(In reply to Katrin Fischer from comment #7)
> Claudio and Jimmy, how did you test?

In a local installation, Katrin
Comment 9 Katrin Fischer 2023-09-05 11:14:43 UTC
(In reply to Claudio Costales from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > Claudio and Jimmy, how did you test?
> 
> In a local installation, Katrin

Package installation or development/git installation? Asking because the patch itself makes sense to me and I wonder if maybe a missing Plack restart or similar could have been the culprit.
Comment 10 Claudio Costales 2023-09-05 11:58:19 UTC
(In reply to Katrin Fischer from comment #9)
> (In reply to Claudio Costales from comment #8)
> > (In reply to Katrin Fischer from comment #7)
> > > Claudio and Jimmy, how did you test?
> > 
> > In a local installation, Katrin
> 
> Package installation or development/git installation? Asking because the
> patch itself makes sense to me and I wonder if maybe a missing Plack restart
> or similar could have been the culprit.


Package installation.

Katrin, I followed your suggestion and it works (Restarted memcached and plack). 

Thanks for your patience.
Comment 11 ByWater Sandboxes 2023-09-14 16:48:20 UTC
Created attachment 155625 [details] [review]
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Comment 12 Christopher Brannon 2023-09-14 16:49:02 UTC
Works as described.  Great job!
Comment 13 Katrin Fischer 2023-09-17 13:31:02 UTC
Created attachment 155756 [details] [review]
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Tomás Cohen Arazi 2023-09-18 15:04:14 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 15 Christopher Brannon 2023-09-18 15:50:50 UTC
Please backport to 22.11 if possible.  Needed functionality.
Comment 16 Fridolin Somers 2023-09-18 20:54:56 UTC
Pushed to 23.05.x for 23.05.04
Comment 17 Laura O'Neil 2023-09-26 20:08:56 UTC
Is there any chance this can be backported into 22.11, please?
Comment 18 Christopher Brannon 2023-09-26 20:13:22 UTC
(In reply to Laura O'Neil from comment #17)
> Is there any chance this can be backported into 22.11, please?

+1
Comment 19 Claudio Costales 2023-09-26 20:21:45 UTC
(In reply to Laura O'Neil from comment #17)
> Is there any chance this can be backported into 22.11, please?

+1
Comment 20 Matt Blenkinsop 2023-09-28 09:07:39 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 21 Christopher Brannon 2023-10-03 19:33:07 UTC
(In reply to Matt Blenkinsop from comment #20)
> Nice work everyone!
> 
> Pushed to oldstable for 22.11.x

Thank you!  :)