Bug 34634 - Expiration date does not display on reserve/request.pl if date is today or in the past
Summary: Expiration date does not display on reserve/request.pl if date is today or in...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks: 35559
  Show dependency treegraph
 
Reported: 2023-08-28 21:55 UTC by Lucas Gass
Modified: 2024-04-30 13:00 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34634: Show expirationdate of expired holds on reserve/request.pl (2.68 KB, patch)
2023-08-28 22:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34634: Show expirationdate of expired holds on reserve/request.pl (2.76 KB, patch)
2023-08-29 10:49 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 34634: Show expirationdate of expired holds on reserve/request.pl (2.80 KB, patch)
2023-08-29 15:39 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-08-28 21:55:01 UTC
To recreate:

1. Place some holds and go to /reserve/request.pl for that bib.
2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance.
3. Change the reserves.expirationdate to sometime in the future, the date displays.

If staff cannot edit the reserves.expirationdate because it is in the past it still needs to display.
Comment 1 Lucas Gass 2023-08-28 22:31:52 UTC
Created attachment 154891 [details] [review]
Bug 34634: Show expirationdate of expired holds on reserve/request.pl

To test:
1. Place some holds and go to /reserve/request.pl for that bib.
2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance.
3. Change the reserves.expirationdate to sometime in the future, the date displays.
4. Aply patch, restart_all
5. Try steps 2-3 again.
6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable.
7. Make sure holds with a expiration date in the future can still be properly edited.
Comment 2 Matt Blenkinsop 2023-08-29 10:49:03 UTC
Created attachment 154899 [details] [review]
Bug 34634: Show expirationdate of expired holds on reserve/request.pl

To test:
1. Place some holds and go to /reserve/request.pl for that bib.
2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance.
3. Change the reserves.expirationdate to sometime in the future, the date displays.
4. Aply patch, restart_all
5. Try steps 2-3 again.
6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable.
7. Make sure holds with a expiration date in the future can still be properly edited.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 ByWater Sandboxes 2023-08-29 15:39:27 UTC
Created attachment 154905 [details] [review]
Bug 34634: Show expirationdate of expired holds on reserve/request.pl

To test:
1. Place some holds and go to /reserve/request.pl for that bib.
2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance.
3. Change the reserves.expirationdate to sometime in the future, the date displays.
4. Aply patch, restart_all
5. Try steps 2-3 again.
6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable.
7. Make sure holds with a expiration date in the future can still be properly edited.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Christine <chlee@pascolibraries.org>
Comment 4 Emily Lamancusa 2023-08-31 17:52:52 UTC
Straightforward change, works nicely, QA tool happy. Passing QA
Comment 5 Tomás Cohen Arazi 2023-09-01 15:09:25 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 06:13:35 UTC
Pushed to 23.05.x for 23.05.04
Comment 7 Matt Blenkinsop 2023-09-15 09:33:55 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x