Bug 34804 - Translation fixes - ERM
Summary: Translation fixes - ERM
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-15 15:50 UTC by Matt Blenkinsop
Modified: 2024-07-04 20:40 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:

Attachments
Bug 34804: Fix translations (4.32 KB, patch)
2023-09-15 15:53 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 34804: Fix translations (4.79 KB, patch)
2023-09-19 10:25 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 34804: Fix translations (4.29 KB, patch)
2023-09-19 12:19 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 34804: Fix translations (4.35 KB, patch)
2023-09-19 13:15 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34804: Fix translations (4.40 KB, patch)
2023-09-19 19:08 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-09-15 15:50:52 UTC 
It looks like some strings aren't formatted correctly for translation in some ERM components. They should be wrapped in this.$__()
Comment 1 Matt Blenkinsop 2023-09-15 15:53:40 UTC 
Created attachment 155695 [details] [review]
Bug 34804: Fix translations

This patch fixes some translations in the ERM module

Translations should be wrapped in this.$__()
Comment 2 Jonathan Druart 2023-09-18 20:15:22 UTC 
Does this work for you?

I am getting an error in the console

Uncaught TypeError: this is undefined
Comment 3 Jonathan Druart 2023-09-18 20:20:56 UTC 
We need to use __("") instead of _("")
Comment 4 Matt Blenkinsop 2023-09-19 10:25:11 UTC 
Created attachment 155888 [details] [review]
Bug 34804: Fix translations

This patch fixes some translations in the ERM module

Translations should be wrapped in this.$__()
Comment 5 Matt Blenkinsop 2023-09-19 12:19:38 UTC 
Created attachment 155893 [details] [review]
Bug 34804: Fix translations

This patch fixes some translations in the ERM module

Translations should be wrapped in this.$__()
Comment 6 Jonathan Druart 2023-09-19 13:15:13 UTC 
Created attachment 155894 [details] [review]
Bug 34804: Fix translations

This patch fixes some translations in the ERM module

Translations should be wrapped in this.$__()

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Katrin Fischer 2023-09-19 19:08:36 UTC 
Created attachment 155908 [details] [review]
Bug 34804: Fix translations

This patch fixes some translations in the ERM module

Translations should be wrapped in this.$__()

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-09-19 19:40:13 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-05 18:20:33 UTC 
Pushed to 23.05.x for 23.05.05
Comment 10 Matt Blenkinsop 2023-10-17 16:56:57 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x