Bug 34822 - BatchUpdateBiblioHoldsQueue should be called once per import batch when using RealTimeHoldsQueue
Summary: BatchUpdateBiblioHoldsQueue should be called once per import batch when using...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 29346
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-18 17:25 UTC by Nick Clemens
Modified: 2023-10-25 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34822: Process real time holds along with indexing (2.71 KB, patch)
2023-09-18 17:29 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 34822: Process real time holds along with indexing (3.32 KB, patch)
2023-09-18 17:36 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 34822: Process real time holds along with indexing (3.36 KB, patch)
2023-09-26 14:08 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34822: Process real time holds along with indexing (3.42 KB, patch)
2023-10-03 11:27 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-09-18 17:25:06 UTC

    
Comment 1 Nick Clemens 2023-09-18 17:29:21 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2023-09-18 17:36:51 UTC
Created attachment 155857 [details] [review]
Bug 34822: Process real time holds along with indexing

Current code already skips indexing when adding record to instead index in a single call. This patch pdates the code to do the same thing for real time holds queue updates.

Note: Newly added records do not need to be updated as they won't have holds yet.

To test:
1 - Have a marc file with several records that match records in your catalog
    You can export part of your catalog to generate one
2 - Set system preference:  RealTimeHoldsQueue to 'enable'
3 - Stage and import file, make sure you are matching and overlaying
4 - Go to Administration->Manage jobs
5 - Note a batch update for each updated record
6 - Apply patch
7 - Repeat
8 - Note a single job added for the entire batch containing only updated records
Comment 3 Sam Lau 2023-09-26 14:08:33 UTC
Created attachment 156231 [details] [review]
Bug 34822: Process real time holds along with indexing

Current code already skips indexing when adding record to instead index in a single call. This patch pdates the code to do the same thing for real time holds queue updates.

Note: Newly added records do not need to be updated as they won't have holds yet.

To test:
1 - Have a marc file with several records that match records in your catalog
    You can export part of your catalog to generate one
2 - Set system preference:  RealTimeHoldsQueue to 'enable'
3 - Stage and import file, make sure you are matching and overlaying
4 - Go to Administration->Manage jobs
5 - Note a batch update for each updated record
6 - Apply patch
7 - Repeat
8 - Note a single job added for the entire batch containing only updated records

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Katrin Fischer 2023-10-03 11:27:37 UTC
Created attachment 156498 [details] [review]
Bug 34822: Process real time holds along with indexing

Current code already skips indexing when adding record to instead index in a single call. This patch pdates the code to do the same thing for real time holds queue updates.

Note: Newly added records do not need to be updated as they won't have holds yet.

To test:
1 - Have a marc file with several records that match records in your catalog
    You can export part of your catalog to generate one
2 - Set system preference:  RealTimeHoldsQueue to 'enable'
3 - Stage and import file, make sure you are matching and overlaying
4 - Go to Administration->Manage jobs
5 - Note a batch update for each updated record
6 - Apply patch
7 - Repeat
8 - Note a single job added for the entire batch containing only updated records

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-10-03 11:30:21 UTC
I am not sure if this could be unit tested, but I ran the existing tests and they still pass ok: t/db_dependent/ImportBatch.t

The detailed BatchUpdateBiblioHoldsQueue job info doesn't look nice yet. Filed:
Bug 34975 - Job details for BatchUpdateBiblioHoldsQueue lack information
Comment 6 Tomás Cohen Arazi 2023-10-04 13:15:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-05 19:49:20 UTC
Pushed to 23.05.x for 23.05.05
Comment 8 Matt Blenkinsop 2023-10-17 16:57:00 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 9 Aleisha Amohia 2023-10-25 20:44:38 UTC
*** Bug 35156 has been marked as a duplicate of this bug. ***