Caught by 34841 To recreate root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/Koha/Auth/Permissions.t t/Koha/Auth/Permissions.t .. 1/3 # Failed test 'Expected permissions generated for superlibrarian' # at t/Koha/Auth/Permissions.t line 285. # Structures begin differing at: # $got->{CAN_user_editcatalogue_manage_item_editor_templates} = '1' # $expected->{CAN_user_editcatalogue_manage_item_editor_templates} = Does not exist # Looks like you failed 1 test of 1. # Failed test 'superlibrarian tests' # at t/Koha/Auth/Permissions.t line 286. # Looks like you failed 1 test of 3. Please fix ASAP.
Created attachment 155931 [details] [review] Bug 34844: Add manage_item_editor_templates to userpermissions.sql Test Plan: 1) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 2) Note failure 3) Apply this patch 4) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 5) Tests pass!
Thanks, Kyle!
Created attachment 155933 [details] [review] Bug 34844: Add manage_item_editor_templates to userpermissions.sql Test Plan: 1) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 2) Note failure 3) Apply this patch 4) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 5) Tests pass! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
We are missing an atomic update.
Created attachment 155994 [details] [review] Bug 34844: Add db update file
Created attachment 155995 [details] [review] Bug 34844: Add db update file
Created attachment 155996 [details] [review] Bug 34844: Add db update file
WARN installer/data/mysql/atomicupdate/bug_34844.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) * Proving /usr/share/koha/t/Koha/Auth/Permissions.t KO! # Failed test 'Expected permissions generated for superlibrarian' # at /usr/share/koha/t/Koha/Auth/Permissions.t line 286. # Structures begin differing at: # $got->{CAN_user_editcatalogue_manage_item_editor_templates} = Does not exist # $expected->{CAN_user_editcatalogue_manage_item_editor_templates} = '1' # Looks like you failed 1 test of 1.
Created attachment 156034 [details] [review] Bug 34844: Add manage_item_editor_templates to userpermissions.sql Test Plan: 1) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 2) Note failure 3) Apply this patch 4) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 5) Tests pass! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 156035 [details] [review] Bug 34844: Add db update file JD amended patch: tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 156045 [details] [review] Bug 34844: Add manage_item_editor_templates to userpermissions.sql Test Plan: 1) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 2) Note failure 3) Apply this patch 4) perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only; prove t/Koha/Auth/Permissions.t 5) Tests pass! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 156046 [details] [review] Bug 34844: Add db update file JD amended patch: tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Small typo at end of atomic update : +++ b/installer/data/mysql/atomicupdate/bug_34844.pl ... + + say $out "Added new permission 'manage_item_editor_templates'"; + }, + } Should be : +};
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x