The syspref needs to be mocked, or the tests are failing. To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t t/db_dependent/Acquisition/GetBasketGroupAsCSV.t .. 1/2 # Failed test 'CSV should be generated' # at t/db_dependent/Acquisition/GetBasketGroupAsCSV.t line 62. # got: '"Account number";"Basket name";"Order number";"Author";"Title";"Publisher";"Publication year";"Collection title";"ISBN";"Quantity";"RRP tax included";"RRP tax excluded";"Discount";"Estimated cost tax included";"Estimated cost tax excluded";"Note for vendor";"Entry date";"Bookseller name";"Bookseller physical address";"Bookseller postal address";"Contract number";"Contract name";"Basket group delivery place";"Basket group billing place";"Basket delivery place";"Basket billing place"# ;"";1;"King, Stephen";"Test Record";"";;"";;3;0.00;0.00;;0.00;0.00;"";2016-01-02;"my vendor";"vendor address";"";;"";"";"";"";""# ' # expected: '"Account number","Basket name","Order number","Author","Title","Publisher","Publication year","Collection title","ISBN","Quantity","RRP tax included","RRP tax excluded","Discount","Estimated cost tax included","Estimated cost tax excluded","Note for vendor","Entry date","Bookseller name","Bookseller physical address","Bookseller postal address","Contract number","Contract name","Basket group delivery place","Basket group billing place","Basket delivery place","Basket billing place"# ,"",1,"King, Stephen","Test Record","",,"",,3,0.00,0.00,,0.00,0.00,"",2016-01-02,"my vendor","vendor address","",,"","","","",""# ' # Failed test 'CSV should not fail if biblio does not exist' # at t/db_dependent/Acquisition/GetBasketGroupAsCSV.t line 73. # got: '"Account number";"Basket name";"Order number";"Author";"Title";"Publisher";"Publication year";"Collection title";"ISBN";"Quantity";"RRP tax included";"RRP tax excluded";"Discount";"Estimated cost tax included";"Estimated cost tax excluded";"Note for vendor";"Entry date";"Bookseller name";"Bookseller physical address";"Bookseller postal address";"Contract number";"Contract name";"Basket group delivery place";"Basket group billing place";"Basket delivery place";"Basket billing place" # ;"";1;"";"";"";;"";;3;0.00;0.00;;0.00;0.00;"";2016-01-02;"my vendor";"vendor address";"";;"";"";"";"";"" # ' # expected: '"Account number","Basket name","Order number","Author","Title","Publisher","Publication year","Collection title","ISBN","Quantity","RRP tax included","RRP tax excluded","Discount","Estimated cost tax included","Estimated cost tax excluded","Note for vendor","Entry date","Bookseller name","Bookseller physical address","Bookseller postal address","Contract number","Contract name","Basket group delivery place","Basket group billing place","Basket delivery place","Basket billing place" # ,"",1,"","","",,"",,3,0.00,0.00,,0.00,0.00,"",2016-01-02,"my vendor","vendor address","",,"","","","","" # ' # Looks like you failed 2 tests of 2.
Created attachment 156084 [details] [review] Bug 34845: Fix GetBasketGroupAsCSV.t is CSVDelimiter is not ','
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 34043 not in 23.05.x