Bug 34930 - Fix timezone problem in Koha/Object.t
Summary: Fix timezone problem in Koha/Object.t
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-27 11:56 UTC by Marcel de Rooy
Modified: 2023-10-17 13:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34930: Change timezone in Koha/Object.t where tests assume it (1.41 KB, patch)
2023-09-27 12:03 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34930: Change timezone in Koha/Object.t where tests assume it (1.43 KB, patch)
2023-09-29 11:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-09-27 11:56:20 UTC
Resolve

        #   Failed test 'Given an rfc3339 formatted datetime string, a timestamp field is converted into an SQL formatted datetime string'
        #   at t/db_dependent/Koha/Object.t line 706.
        #          got: '2019-12-27 15:53:00'
        #     expected: '2019-12-27 14:53:00'

Context: export TZ='Europe/Amsterdam'
Comment 1 Marcel de Rooy 2023-09-27 12:03:36 UTC
Created attachment 156283 [details] [review]
Bug 34930: Change timezone in Koha/Object.t where tests assume it

This is the case for subtest: attributes_from_api() tests.

Test plan:
export TZ='Europe/Amsterdam'
prove t/db_dependent/Koha/Object.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-27 12:04:14 UTC
Trivial: Self SO
Comment 3 Katrin Fischer 2023-09-29 11:37:07 UTC
Created attachment 156384 [details] [review]
Bug 34930: Change timezone in Koha/Object.t where tests assume it

This is the case for subtest: attributes_from_api() tests.

Test plan:
export TZ='Europe/Amsterdam'
prove t/db_dependent/Koha/Object.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi 2023-10-03 12:55:31 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-05 19:19:27 UTC
Pushed to 23.05.x for 23.05.05
Comment 6 Jacob O'Mara 2023-10-17 13:37:58 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x