To recreate: 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
Furthermore, this produces invalid HTML. If you run the outputted HTML through a validator it will tell you: fieldset not allowed as child of element ol
Created attachment 157003 [details] [review] Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly.
Created attachment 157562 [details] [review] Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 158422 [details] [review] Bug 34931: Remove fieldset/legend in favor of div/h3 1. Create some PA_CLASS authorized values. 2. Create some custom patron attributes and add them to the newly created PA_CLASS's. 3. Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'. 4. Go to a new or existing patron record. 5. At the top of the page click the checkbox for "Show collapsed fields:". 6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS. 7. Apply patch 8. Try again, the Additional attributes and identifiers fieldset should display properly. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to 22.11.x for next release