There are some event attributes in the OPAC's bibliographic detail page template. These should be removed in favor of defining events in JavaScript.
Created attachment 156301 [details] [review] Bug 34936: Remove the use of event attributes from OPAC detail page This patch removes the use of event attributes (onclick) from the OPAC's bibliographic detail page template. These events are defined now along with the other in-page JS. The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. In checking for use of the "Dopop" function I found that it was being redefined in opac-topissues.tt for no reason so I removed it. To test you must have the OPACComments system preference enabled. - Log in to the OPAC, locate a bibliographic record, and view the detail page. - Under the "Comments" tab, click the "Post your comments on this title" link. It should trigger a popup window. - Submit your comment. When the detail page reloads, return to the "Comments" tab and click the "Edit" link on your comment. The same popup window should be triggered.
Created attachment 156338 [details] [review] Bug 34936: Remove the use of event attributes from OPAC detail page This patch removes the use of event attributes (onclick) from the OPAC's bibliographic detail page template. These events are defined now along with the other in-page JS. The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. In checking for use of the "Dopop" function I found that it was being redefined in opac-topissues.tt for no reason so I removed it. To test you must have the OPACComments system preference enabled. - Log in to the OPAC, locate a bibliographic record, and view the detail page. - Under the "Comments" tab, click the "Post your comments on this title" link. It should trigger a popup window. - Submit your comment. When the detail page reloads, return to the "Comments" tab and click the "Edit" link on your comment. The same popup window should be triggered. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It work! :D > The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. Nice addition :)
Created attachment 156389 [details] [review] Bug 34936: Remove the use of event attributes from OPAC detail page This patch removes the use of event attributes (onclick) from the OPAC's bibliographic detail page template. These events are defined now along with the other in-page JS. The patch also adjusts the global "Dopop" function so that the popup window is a litte bigger. The comments form did not fit well. In checking for use of the "Dopop" function I found that it was being redefined in opac-topissues.tt for no reason so I removed it. To test you must have the OPACComments system preference enabled. - Log in to the OPAC, locate a bibliographic record, and view the detail page. - Under the "Comments" tab, click the "Post your comments on this title" link. It should trigger a popup window. - Submit your comment. When the detail page reloads, return to the "Comments" tab and click the "Edit" link on your comment. The same popup window should be triggered. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x