Created attachment 156820 [details] [review] Bug 35028: Add pre-registrations alert on staff interface main page Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA)
This looks like it works well but it assumes a procedure for self-registrations which is not necessarily universal. It sounds like the sponsoring library's workflow requires that self-registrations are reviewed by staff, and perhaps the patron category is updated after review? By contrast, in my library we don't do a review of self-registrations which involves a category change. In our case these registrations are not "pre-registered" patrons, they're just patrons. Having a constantly increasing number displayed on the staff home page wouldn't be helpful.
Should I add a syspref then ?
I think a system preference sounds good in that case. I'd also change the terminology. We call the feature "self registration" and it's never appearing as pre-registered. - I'd suggest not to use a new term but stick to what we have already. Maybe: Self registrations: OPAC self registrations:
Created attachment 175390 [details] [review] Bug 35028: Add pre-registrations alert on staff interface main page Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Pre-registered patron(s) from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA)
Created attachment 175391 [details] [review] Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA)
Patch rebased + added a new system preference as suggested
Created attachment 175392 [details] [review] Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA)
Created attachment 175393 [details] [review] Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA)
Created attachment 176399 [details] [review] Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Was using JS to do something like this previously. Nice to see it added for real. :)
Created attachment 176522 [details] [review] Bug 35028: Add self-registrations alert on staff interface main page This adds a new system preference PatronSelfRegistrationAlert to enable or disable alerts (disabled by default) Test plan: 1. Create patron category SELFREG 2. Enable PatronSelfRegistration and set PatronSelfRegistrationDefaultCategory to SELFREG and PatronSelfRegistrationAlert to "Show" 3. Go to OPAC, logout if needed, and create a new account. Remember the value you set for home library. 4. Go to staff interface, set the current library to the one you set in step 3. 5. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1 / <CURRENT LIBRARY>: 1" (numbers can vary if you already had self-registered patrons) 6. Click on both links and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) 7. Set the current library to another one (one that doesn't have self-registered patrons) 8. Go to the staff interface main page. You should see at the bottom a message saying "Self-registrations from: All libraries: 1" (numbers can vary if you already had self-registered patrons) 9. Click on the link and verify that it shows the correct patrons (or redirect to the patron detail page if there is only one) Co-authored-by: Fridolin Somers <fridolin.somers@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Sponsored-by: Écoles nationales supérieures d'architecture (ENSA) Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176523 [details] [review] Bug 35028: (QA follow-up) Fix file permission for DB update Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>