Many libraries find 'Renew or check in selected items' within the issues/checkout table confusing. It makes sense to split these into 2 separate buttons.
Created attachment 157218 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly.
I really like this and it works well except for one issue I've found: After clicking "Renew all" the "Renew selected" button becomes active even though there are no checked checkboxes.
Created attachment 157254 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all
(In reply to Owen Leonard from comment #2) > I really like this and it works well except for one issue I've found: After > clicking "Renew all" the "Renew selected" button becomes active even though > there are no checked checkboxes. Owen, thanks for testing! I have provided a small follow-up and reset to NSO.
I tested this and it works well, except I found one edge case. If you make selections in both the renew and checkin columns and then click one of the buttons to renew or checkin the selected items, when circulation.pl reloads both buttons start as enabled, but they should be disabled like when circulation.pl initially loads.
Created attachment 157357 [details] [review] Bug 35068: (follow-up) Always disable buttons after action
(In reply to Brendan Lawlor from comment #5) > I tested this and it works well, except I found one edge case. If you make > selections in both the renew and checkin columns and then click one of the > buttons to renew or checkin the selected items, when circulation.pl reloads > both buttons start as enabled, but they should be disabled like when > circulation.pl initially loads. Good catch! I've provided a follow-up.
Created attachment 157465 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 157466 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 157467 [details] [review] Bug 35068: (follow-up) Always disable buttons after action Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 157468 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all
Created attachment 157523 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com>
Created attachment 157524 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com>
Created attachment 157525 [details] [review] Bug 35068: (follow-up) Always disable buttons after action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com>
Created attachment 157526 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all Signed-off-by: Kelly <kelly@bywatersolutions.com>
Created attachment 157552 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Owen, thanks for the follow-up. Those icons look good!
Looks good, but wondering about: Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. The item is checked in. But the tab still lists two checkouts (wrong). And the selection for renew is gone. Uncomfortable? Suppose I had a large selection?
(In reply to Marcel de Rooy from comment #18) > The item is checked in. But the tab still lists two checkouts (wrong). This is not related to this patch. That's the existing behavior. > And the selection for renew is gone. Uncomfortable? Suppose I had a large > selection? I agree that this is a problem
> And the selection for renew is gone. Uncomfortable? Suppose I had a large > selection? Good catch, I think I have a solution.
Created attachment 158343 [details] [review] Bug 35068: (follow-up): Make sure renew/checkin selections get retained on reload To test: 1. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 2. When the table reloads the 'renew' selections should be retained 3. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 4. When the table reloads the 'check in' selections should be retained
I think it is now prudent here to get another sign-off so I have reset to NSO.
> The item is checked in. But the tab still lists two checkouts (wrong). I have filed a separate bug for this issue since it happens with or without my patch.
Created attachment 158476 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158477 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158478 [details] [review] Bug 35068: (follow-up) Always disable buttons after action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158479 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158480 [details] [review] Bug 35068: (follow-up): Make sure renew/checkin selections get retained on reload To test: 1. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 2. When the table reloads the 'renew' selections should be retained 3. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 4. When the table reloads the 'check in' selections should be retained Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158481 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Do the test plan of 5th patch "Make sure renew/checkin selections" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158482 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158483 [details] [review] Bug 35068: (follow-up) Always disable buttons after action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158484 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 158485 [details] [review] Bug 35068: (follow-up): Make sure renew/checkin selections get retained on reload To test: 1. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 2. When the table reloads the 'renew' selections should be retained 3. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 4. When the table reloads the 'check in' selections should be retained Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Amended test plan to mention the 2nd test plan. It's not reliable to have other test plans in follow-up without having the 1st test plan point to them. I hope I never missed such cases in the past >_< Anyway, it works! :D And the functional chance makes sense. I was always confused about that 2 in one button.
I'd be tempted to tie the buttons even more directly to the select columns they adhere to.. perhaps a second footer row for actions buttons that pertain to the column above them?
Looking here
(In reply to Martin Renvoize from comment #35) > I'd be tempted to tie the buttons even more directly to the select columns > they adhere to.. perhaps a second footer row for actions buttons that > pertain to the column above them? I dont think that we should block this now. But personally the buttons and checkboxes are a bit confusing. If I click one renew checkbox, I would expect Renew all to be disabled for instance. Renew all is now a shortcut for Select all+Renew selected. Could we do without it? We dont have Checkin all which is just Select all+Checkin selected. Feels like an inconsistency? What about (just brainstorming, sorry): Checkin = Checkin All when no checkbox is enabled. Same for Renew. As soon as you select a checkbox, the button becomes an action for selected lines.
Created attachment 158788 [details] [review] Bug 35068: Split RenewCheckinChecked button into seperate renew/checkin buttons To test: 1. APPLY patch, clear browser's cache 2. Have more than 1 checkout issued to a borrower. 3. Load the checkout table on circ/circulation.pl 4. Notice that there is now 'Renew selected items' and 'Checkin selected items' button. 5. Play around with each making sure that they work as excepted when checkouts are checked in either the 'Check in' or 'Renew' columns. 6. Uncheck everything in the 'Renew column', the 'Renew selected items' button should be disabled. 7. Uncheck everything in the 'Checkin column', the 'Checkin selected items' button should be disabled. 8. Try unchecking some of these to make sure the Renew/Checkin button is properly disabled when no related checkboxes are checked. 9. Try using the select all/none options at the top of both the 'Renew' and 'Checkin' columns. Make sure the 'Renew selected items' and 'Checkin selected items' become properly disabled/enabled. 10. Make sure the 'Renew all' button still works properly. 11. Do the test plan of 5th patch "Make sure renew/checkin selections" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 158789 [details] [review] Bug 35068: (follow-up) Disable button after clicking Renew all Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 158790 [details] [review] Bug 35068: (follow-up) Always disable buttons after action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 158791 [details] [review] Bug 35068: (follow-up) Update button order and icons This patch updates the Renew and Check-in buttons so that they have icons matching the ones used for the Renew and Check-in search tabs in the header. The patch also moves the Renew button so that it is next to the Renew all button. I think this makes more logical sense. So the order is: - Check in selected items - Renew selected items - Renew all Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 158792 [details] [review] Bug 35068: (follow-up): Make sure renew/checkin selections get retained on reload To test: 1. Have two checkouts. Click one for Renew and one for Checkin. Click on Check in selected items. 2. When the table reloads the 'renew' selections should be retained 3. Have two checkouts. Click one for Renew and one for Checkin. Click on Renew selected items. 4. When the table reloads the 'check in' selections should be retained Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x
(In reply to Marcel de Rooy from comment #37) > (In reply to Martin Renvoize from comment #35) > > I'd be tempted to tie the buttons even more directly to the select columns > > they adhere to.. perhaps a second footer row for actions buttons that > > pertain to the column above them? > > I dont think that we should block this now. But personally the buttons and > checkboxes are a bit confusing. If I click one renew checkbox, I would > expect Renew all to be disabled for instance. > Renew all is now a shortcut for Select all+Renew selected. Could we do > without it? We dont have Checkin all which is just Select all+Checkin > selected. Feels like an inconsistency? > > What about (just brainstorming, sorry): Checkin = Checkin All when no > checkbox is enabled. Same for Renew. As soon as you select a checkbox, the > button becomes an action for selected lines. Did we open a new bug for this?