Bug 35075 - "bulkmarcimport" source missing in Marc Overlay Rules settings page
Summary: "bulkmarcimport" source missing in Marc Overlay Rules settings page
Status: RESOLVED DUPLICATE of bug 25539
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Michał
QA Contact: Testopia
URL:
Keywords:
Depends on: 25539
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-17 09:38 UTC by Michał
Modified: 2024-01-03 16:39 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 35075: "bulkmarcimport" source missing in Marc Overlay Rules settings page (1.40 KB, patch)
2023-10-23 13:27 UTC, Michał
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michał 2023-10-17 09:38:21 UTC
For some reason it's commented out here:
https://github.com/Koha-Community/Koha/blob/f27ed123be8ac1f0ecd76cd54ed9c2a8e591aefe/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt#L476

Even though it's a valid source, as shown here:
https://github.com/Koha-Community/Koha/blob/f27ed123be8ac1f0ecd76cd54ed9c2a8e591aefe/misc/migration_tools/bulkmarcimport.pl#L448

Which is analogous to import_lexile.pl script's source here, which isn't commented out:
https://github.com/Koha-Community/Koha/blob/f27ed123be8ac1f0ecd76cd54ed9c2a8e591aefe/misc/migration_tools/import_lexile.pl#L199

So I think it should be commented out, because we have a use-case to specify it, and we cannot use "*" as that also prevents manual staff staff edit, so the only workaround for now is to manually change the field in the SQL database...
Comment 1 Michał 2023-10-23 13:27:16 UTC
Created attachment 157653 [details] [review]
Bug 35075: "bulkmarcimport" source missing in Marc Overlay  Rules settings page
Comment 2 David Nind 2023-10-25 19:46:20 UTC
Happy to try and test.

Could you please add a test plan to the commit message? (See the https://wiki.koha-community.org/wiki/Commit_messages#Test_plan)

It will also need a bug/feature description as well, to keep the QA Team happy.

Thanks.

David
Comment 3 Martin Renvoize (ashimema) 2023-10-31 13:45:24 UTC
It was commented out because there were blockers to it actually working... I have a feeling those blockers are still being worked on at the moment.
Comment 4 Martin Renvoize (ashimema) 2023-10-31 13:46:07 UTC
Yes, take a look at the depends on above..  it's commented out at the moment to prevent it's use whilst that bug works through.
Comment 5 Martin Renvoize (ashimema) 2024-01-03 16:39:02 UTC

*** This bug has been marked as a duplicate of bug 25539 ***