I've run across a case where the database upgrade in Bug 31383 triggers an error. The error is: ERROR - {UNKNOWN}: Not a HASH reference at /kohadevbox/koha/installer/data/mysql/db_revs/230600041.pl line 130. at /kohadevbox/koha/C4/Installer.pm line 741 I noticed that the error didn't happen if I deleted the 'ISSUESLIP' notice before running the upgrade, and that the error only happened with my custom testing database, not the default Koha testing data. Comparing the contents of ISSUESLIP in my data and in the default, I see this difference: In my data: <p style="margin-bottom: 1px; margin-top: 1px"><<additional_contents.new>></p> In the default data: <p style="margin-bottom: 1px; margin-top: 1px"><<additional_contents.content>></p> I'm not sure where the difference comes in, or how common this case might be in the wild.
Created attachment 157724 [details] [review] Bug 35136: (bug 31383 follow-up) Fix db rev
There is an obvious mistake, could you try with this patch please?
Created attachment 157740 [details] [review] Bug 35136: (bug 31383 follow-up) Fix db rev Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 157750 [details] [review] Bug 35136: (bug 31383 follow-up) Fix db rev Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :) Reproduced the error and confirmed that with the fix, updatedatabase works and notifies that ISSUESLIP needs to be manually fixed.
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 31383 not in 23.05.x