Building on 22318, the RoutingListNote system preference should be converted to an HTML customization option.
Created attachment 158747 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option.
Created attachment 159718 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind <david@davidnind.com>
I can see one minor issue: if RoutingListNote preference still have its default value (which is: To change this note edit <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped">RoutingListNote</a> system preference.) it's copied over to the HTML customization and it now contains a link to a removed preference. I'm not sure of what should be done about it. Should we rewrite it in the db update ? Should we remove it ?
Is this bug really dependent on bug 35151 ?
(In reply to Julian Maurice from comment #3) > I can see one minor issue: if RoutingListNote preference still have its > default value Did the database update not take care of this? (In reply to Julian Maurice from comment #4) > Is this bug really dependent on bug 35151 ? Probably not... I was trying to make each one of these HTML customization patches dependent on the previous one to avoid conflicts.
(In reply to Owen Leonard from comment #5) > (In reply to Julian Maurice from comment #3) > > I can see one minor issue: if RoutingListNote preference still have its > > default value > > Did the database update not take care of this? The database update moves RoutingListNote preference content to a new HTML customization, but does nothing to detect if it still has its default value
Please QA - it's blocking other dependent bugs!
Doesn't apply, and comment 6 needs an update I think just: if ($routinglistnote) { $routinglistnote = "You can edit this note in the HTML customizations section of Koha <link> to the page" if $routinglistnote eq q{To change this note edit <a href=\"/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RoutingListNote#jumped\">RoutingListNote</a> system preference.}
Created attachment 167241 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168011 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 170713 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 171030 [details] [review] Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind <david@davidnind.com>